From mboxrd@z Thu Jan  1 00:00:00 1970
From: Corneliu ZUZU <czuzu@bitdefender.com>
Subject: Re: [PATCH 1/7] arm: move arch/arm/hvm.c to
	arch/arm/hvm/hvm.c
Date: Tue, 9 Feb 2016 13:28:03 +0200
Message-ID: <56B9CD43.5060009@bitdefender.com>
References: <1454950682-9459-1-git-send-email-czuzu@bitdefender.com>
	<1454950682-9459-2-git-send-email-czuzu@bitdefender.com>
	<alpine.DEB.2.02.1602091058510.27008@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1602091058510.27008@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Tamas K Lengyel <tamas@tklengyel.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Razvan Cojocaru <rcojocaru@bitdefender.com>, Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xen.org, Stefano Stabellini <stefano.stabellini@citrix.com>, Jun Nakajima <jun.nakajima@intel.com>
List-Id: xen-devel@lists.xenproject.org

On 2/9/2016 1:03 PM, Stefano Stabellini wrote:
> On Mon, 8 Feb 2016, Corneliu ZUZU wrote:
>> X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry,
>> also move arch/arm/hvm.c to arch/arm/hvm/hvm.c.
> Why are we doing this? These are not header files, their paths don't
> necessarily need to be the same and xen/arch/x86/hvm/hvm.c is very
> different from xen/arch/arm/hvm.c.
>
> Please state the reason more clearly.
>
>
>> Signed-off-by: Corneliu ZUZU <czuzu@bitdefender.com>
>> ---
>>   xen/arch/arm/Makefile     |  2 +-
>>   xen/arch/arm/hvm.c        | 67 -----------------------------------------------
>>   xen/arch/arm/hvm/Makefile |  1 +
>>   xen/arch/arm/hvm/hvm.c    | 66 ++++++++++++++++++++++++++++++++++++++++++++++
>>

Because the ARM side hvm.c currently exists solely to add an implementation for
do_hvm_op, which on x86 is @ arch/x86/hvm/hvm.c. I presume the ARM hvm.c got its name
from the X86 file, so I thought a symmetry between the two was intended from the start.
Also, the hvm directory was created to separate hvm-specific code, which is the case w/
do_hvm_op on any arch.

Corneliu.