From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 09 Feb 2016 13:38:41 +0100 (CET) Received: from mail.bmw-carit.de ([62.245.222.98]:59467 "EHLO mail.bmw-carit.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010933AbcBIMigxUO1b (ORCPT ); Tue, 9 Feb 2016 13:38:36 +0100 Received: from exchange2010.bmw-carit.intra ([192.168.100.28]:46676 helo=mail.bmw-carit.de) by mail.bmw-carit.de with esmtps (TLSv1:AES256-SHA:256) (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1aT7Yw-0000tP-2P; Tue, 09 Feb 2016 13:38:34 +0100 Received: from handman.bmw-carit.intra (192.168.101.8) by Exchange2010.bmw-carit.intra (192.168.100.28) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 9 Feb 2016 13:38:34 +0100 X-CTCH-RefID: str=0001.0A0C0202.56B9DDCA.025E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Subject: Re: [PATCH v3 3/3] mips: Differentiate between 32 and 64 bit ELF header To: "Maciej W. Rozycki" References: <201602090033.mukhdG4N%fengguang.wu@intel.com> <56B99D55.2020301@bmw-carit.de> CC: kbuild test robot , , Ralf Baechle , , From: Daniel Wagner Message-ID: <56B9DDCA.3000700@bmw-carit.de> Date: Tue, 9 Feb 2016 13:38:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 51903 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: daniel.wagner@bmw-carit.de Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 02/09/2016 01:32 PM, Maciej W. Rozycki wrote: > FWIW I think all the MIPS ABI flags stuff also needs to go outside the > conditional, because it's ABI agnostic. I'll make the right change myself > on top of your fixes. It'll remove a little bit of code duplication, > which is always welcome. Great, thanks for taking care of it. cheers, daniel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.bmw-carit.de ([62.245.222.98]:59467 "EHLO mail.bmw-carit.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010933AbcBIMigxUO1b (ORCPT ); Tue, 9 Feb 2016 13:38:36 +0100 Subject: Re: [PATCH v3 3/3] mips: Differentiate between 32 and 64 bit ELF header References: <201602090033.mukhdG4N%fengguang.wu@intel.com> <56B99D55.2020301@bmw-carit.de> From: Daniel Wagner Message-ID: <56B9DDCA.3000700@bmw-carit.de> Date: Tue, 9 Feb 2016 13:38:34 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: "Maciej W. Rozycki" Cc: kbuild test robot , kbuild-all@01.org, Ralf Baechle , linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Message-ID: <20160209123834.Tv6xTURP97GmFixeprR33RRFraJ42w1qyzH1GZNQ0RM@z> On 02/09/2016 01:32 PM, Maciej W. Rozycki wrote: > FWIW I think all the MIPS ABI flags stuff also needs to go outside the > conditional, because it's ABI agnostic. I'll make the right change myself > on top of your fixes. It'll remove a little bit of code duplication, > which is always welcome. Great, thanks for taking care of it. cheers, daniel