From mboxrd@z Thu Jan 1 00:00:00 1970 From: elfring@users.sourceforge.net (SF Markus Elfring) Date: Tue, 9 Feb 2016 13:55:30 +0100 Subject: [Cocci] coccinelle: add style check for assignment in if In-Reply-To: References: <1454935571-4054-1-git-send-email-kborer@gmail.com> <56B9A2F6.4040109@users.sourceforge.net> Message-ID: <56B9E1C2.7070008@users.sourceforge.net> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr >> Would you like to consider also the reuse of SmPL variables >> like "org" and "report"? > > I think that there is no point for these things, because checkpatch > already gives warnings about this issue. Can the check result display be more convenient from the semantic patch script interface in comparison to the other tool? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755345AbcBIMzm (ORCPT ); Tue, 9 Feb 2016 07:55:42 -0500 Received: from mout.web.de ([212.227.17.12]:60275 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752462AbcBIMzk (ORCPT ); Tue, 9 Feb 2016 07:55:40 -0500 Subject: Re: coccinelle: add style check for assignment in if To: Julia Lawall References: <1454935571-4054-1-git-send-email-kborer@gmail.com> <56B9A2F6.4040109@users.sourceforge.net> Cc: Kris Borer , Michal Marek , Gilles Muller , Nicolas Palix , linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr From: SF Markus Elfring Message-ID: <56B9E1C2.7070008@users.sourceforge.net> Date: Tue, 9 Feb 2016 13:55:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ieiSEU0mlgEccutq26/37cYJfdZ/vXuVrddvisGs0t5iDFsKHfh R7krOAPFQHTm/EbDiXbaXqmhLp17qV2D4pz6JJPloRH9pv72S/zuCr2JBhroCxN+DNAEwfw gbupEa3BQZP6yhUpHrVt/g8ZGPF9/YSai5xc6HXPCgc5ujMWPQErfltTN5zCp23+8LVNmd6 ALtMynEqtyPzFlpzgOCfA== X-UI-Out-Filterresults: notjunk:1;V01:K0:gGqqiq1a1qI=:9Aj26djnehBHUE1dutchcr PsytXlnF/P0zhAcAIfzD/uxZzJASqEOuPxQ6xDT5SwGRz33pcEFIFobN/MHVr/QPkpMmD87ts UKTknqpIC5Yj+bHyflnBd73ZJpn61CiNTaVeZEQMseHTjScjz/pafNPjRNuKPMFx6F+LmwX12 bp6V/lXVGAr2ZMxCiNuyCivVbmF/revX2aaeoRw9QzDCMifSCeNPeV9Zdsh/xwXt56rKbtGW/ e9hKRHYOdcpA7440BPlCw52jfA71T6/KbrNkXOEWb/ct41cuQGqTMdUJPKJ3rKP53SCBwg2n9 QpYdFi6jod7o2loAW74nvJd55Q4wI5Ca9tFyS8sUMK9E3DIqXhp7vuVVaEUVVLv0BN/W0gukt TPwRoYvq/zRZSKuEIJHWWTv2uIWC31mP43BGMXlVpxDJmPWSqJbRrpff29XamqphPR+hvb7Gp 1wcCKadO5p116YwMs/+t/jjG4+EkjL7+TnOItqTjr9RNPSLjvo4uDVLyZkFUshnHC6DNwwA5i LPAyqkcD6UCiVZV1DY/gR1uGP0sUfk0VQp5RamQm1Wr8WTA0NHjAA/cp9CwucTnHF8yP99Lmw hC+pRs3CyEjKtwLXHOpgTxlZReqeJUvFzdajWcX6MK9Sf795OPSnLVzlZajT8d5ZI8tWD3OZI 1mGIqb7wm9z0CpMnIkjhS7YdHXXPdhIf7z5g1YS1WshKO7OxnJ4SzaP0PDVvpR4azXa5WglqJ 9m6H5pX4sAbHJJhIaDHT2Bm5KltRUyIMmpzy4Oi+bg7BIpS6bhpE4bUagaS4sZ8qU+jx9K5g/ RMxt8bl Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Would you like to consider also the reuse of SmPL variables >> like "org" and "report"? > > I think that there is no point for these things, because checkpatch > already gives warnings about this issue. Can the check result display be more convenient from the semantic patch script interface in comparison to the other tool? Regards, Markus