From: Greg Ungerer <gerg@uclinux.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org
Subject: Re: [PATCH] m68k: use conventional function parameters for do_sigreturn
Date: Tue, 9 Feb 2016 23:05:57 +1000 [thread overview]
Message-ID: <56B9E435.2000203@uclinux.org> (raw)
In-Reply-To: <mvmegcmw6y1.fsf@hawking.suse.de>
On 09/02/16 19:48, Andreas Schwab wrote:
> Greg Ungerer <gerg@uclinux.org> writes:
>
>> Should I submit a gcc bug report?
>
> No, it's not a bug. Function parameters are dead after return, so any
> writes to them can be elided.
Given the original code is:
asmlinkage int do_sigreturn(unsigned long __unused)
{
struct switch_stack *sw = (struct switch_stack *) &__unused;
struct pt_regs *regs = (struct pt_regs *) (sw + 1);
So gcc is determining that what sw and regs points to are
part of do_sigreturn() parameters here?
Given the ugliness of this grunging around in the stack I
still think my original patch to use correct pointer args is
much cleaner all round.
Regards
Greg
next prev parent reply other threads:[~2016-02-09 13:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 5:56 [PATCH] m68k: use conventional function parameters for do_sigreturn Greg Ungerer
2016-02-01 4:33 ` Greg Ungerer
2016-02-01 18:39 ` Andreas Schwab
2016-02-01 23:59 ` Greg Ungerer
2016-02-02 19:25 ` Andreas Schwab
2016-02-03 4:14 ` Greg Ungerer
2016-02-08 23:31 ` Andreas Schwab
2016-02-09 0:21 ` Greg Ungerer
2016-02-09 9:48 ` Andreas Schwab
2016-02-09 13:05 ` Greg Ungerer [this message]
2016-02-09 13:17 ` Andreas Schwab
2016-02-09 14:01 ` Philippe De Muyter
2016-02-09 14:36 ` Andreas Schwab
2016-02-09 15:26 ` Philippe De Muyter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B9E435.2000203@uclinux.org \
--to=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.