From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com. [216.228.121.143]) by gmr-mx.google.com with ESMTPS id 79si1958966pft.0.2016.02.09.06.09.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Feb 2016 06:09:52 -0800 (PST) Message-ID: <56B9F078.1030006@nvidia.com> Date: Tue, 9 Feb 2016 19:28:16 +0530 From: Laxman Dewangan MIME-Version: 1.0 To: Javier Martinez Canillas , , , , , , CC: , , Subject: [rtc-linux] Re: [PATCH V6 1/6] regmap: irq: dispose all virtual irq before removing domain References: <1455020907-4564-1-git-send-email-ldewangan@nvidia.com> <1455020907-4564-2-git-send-email-ldewangan@nvidia.com> <56B9E93A.2040903@osg.samsung.com> In-Reply-To: <56B9E93A.2040903@osg.samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Tuesday 09 February 2016 06:57 PM, Javier Martinez Canillas wrote: > Hello Laxman, > > On 02/09/2016 09:28 AM, Laxman Dewangan wrote: >> It is require to dispose all virtual irq of hwirq on chip >> created on given irq domain before removing this irq domain. >> Hence dispose all mapped irqs before deleting the irq domains >> in regmap_del_irq_chip(); >> >> Signed-off-by: Laxman Dewangan >> > > I believe this patch could be picked separately and not made part of > this series since is fixing a bug that happens on most drivers using > the regmap-irq API. This will avoid cross-subsystem churn for people. > > Your patch 6/6 does not introduce a regression since the bug already > exists in the MFD driver, it just makes it more noticeable since it > is easier to unbind the max77686 RTC driver than the MFD one. If we dont have fix then rtc unbind/bind creates issue on S2R. Although it was issue on tot but the issue visible with my patch only. So if you test my 2 to 6 without 1, you will see issue. So to avoid bisect issue in functionality wise, this should go on sequence. This is my view. -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757282AbcBIOJz (ORCPT ); Tue, 9 Feb 2016 09:09:55 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:16835 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754143AbcBIOJw (ORCPT ); Tue, 9 Feb 2016 09:09:52 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 09 Feb 2016 06:10:17 -0800 Message-ID: <56B9F078.1030006@nvidia.com> Date: Tue, 9 Feb 2016 19:28:16 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Javier Martinez Canillas , , , , , , CC: , , Subject: Re: [PATCH V6 1/6] regmap: irq: dispose all virtual irq before removing domain References: <1455020907-4564-1-git-send-email-ldewangan@nvidia.com> <1455020907-4564-2-git-send-email-ldewangan@nvidia.com> <56B9E93A.2040903@osg.samsung.com> In-Reply-To: <56B9E93A.2040903@osg.samsung.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 09 February 2016 06:57 PM, Javier Martinez Canillas wrote: > Hello Laxman, > > On 02/09/2016 09:28 AM, Laxman Dewangan wrote: >> It is require to dispose all virtual irq of hwirq on chip >> created on given irq domain before removing this irq domain. >> Hence dispose all mapped irqs before deleting the irq domains >> in regmap_del_irq_chip(); >> >> Signed-off-by: Laxman Dewangan >> > > I believe this patch could be picked separately and not made part of > this series since is fixing a bug that happens on most drivers using > the regmap-irq API. This will avoid cross-subsystem churn for people. > > Your patch 6/6 does not introduce a regression since the bug already > exists in the MFD driver, it just makes it more noticeable since it > is easier to unbind the max77686 RTC driver than the MFD one. If we dont have fix then rtc unbind/bind creates issue on S2R. Although it was issue on tot but the issue visible with my patch only. So if you test my 2 to 6 without 1, you will see issue. So to avoid bisect issue in functionality wise, this should go on sequence. This is my view.