From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH V7 8/8] regulator: max77620: add regulator driver for max77620/max20024 Date: Tue, 9 Feb 2016 20:32:24 +0530 Message-ID: <56B9FF80.7010107@nvidia.com> References: <1454171931-27752-1-git-send-email-ldewangan@nvidia.com> <1454171931-27752-9-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from hqemgate16.nvidia.com ([216.228.121.65]:11628 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751197AbcBIPOB (ORCPT ); Tue, 9 Feb 2016 10:14:01 -0500 In-Reply-To: <1454171931-27752-9-git-send-email-ldewangan@nvidia.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com Cc: lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, k.kozlowski@samsung.com, vreddytalla@nvidia.com, Mallikarjun Kasoju Hi Mark, I have taken care of all your previous comment on this patch. Can you please review? I got the macro from Lee's and spinning the V8 of this series so if there is any thing, I can take care on my next version. Thanks, Laxman On Saturday 30 January 2016 10:08 PM, Laxman Dewangan wrote: > MAXIM Semiconductor's PMIC, MAX77620 and MAX20024 have the > multiple DCDC and LDOs. This supplies the power to different > components of the system. > Also these rails has configuration for ramp time, flexible > power sequence, slew rate etc. > > Add regulator driver to access these rails via regulator APIs. > > Signed-off-by: Laxman Dewangan > Signed-off-by: Mallikarjun Kasoju > Reviewed-by: Krzysztof Kozlowski > --- > > - Cleanup code based on comment received on mfd/rtc. > - Avoid duplication on error message. > > Changes form V2: > - Run coccicheck and checkpatch in strict mode for the alignment. > - Refactor Regulator driver to use core API for DT parsing. > - Update based on API changes. > > Changes from V3: > - Change all sys initcall to module driver. > - change the max77620_read argument to unisgned int from u8. > > Changes from V4: > - Added DT binding document as devicetree/bindings/regulator/regulator-max77620.txt > - Detail out properties. > > Changes from V5: > - Separate out DT binding doc for regulator. > > Changes from V6: > - Use direct regmap APIs. > - Drop active-discharge configuration as it wil be move to core and through > callback. Follow on patches are palnned for this. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com. [216.228.121.65]) by gmr-mx.google.com with ESMTPS id 12si4695977pfb.1.2016.02.09.07.14.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Feb 2016 07:14:01 -0800 (PST) Message-ID: <56B9FF80.7010107@nvidia.com> Date: Tue, 9 Feb 2016 20:32:24 +0530 From: Laxman Dewangan MIME-Version: 1.0 To: , , , , , , , , , , CC: , , , , , , , , , Mallikarjun Kasoju Subject: [rtc-linux] Re: [PATCH V7 8/8] regulator: max77620: add regulator driver for max77620/max20024 References: <1454171931-27752-1-git-send-email-ldewangan@nvidia.com> <1454171931-27752-9-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1454171931-27752-9-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hi Mark, I have taken care of all your previous comment on this patch. Can you please review? I got the macro from Lee's and spinning the V8 of this series so if there is any thing, I can take care on my next version. Thanks, Laxman On Saturday 30 January 2016 10:08 PM, Laxman Dewangan wrote: > MAXIM Semiconductor's PMIC, MAX77620 and MAX20024 have the > multiple DCDC and LDOs. This supplies the power to different > components of the system. > Also these rails has configuration for ramp time, flexible > power sequence, slew rate etc. > > Add regulator driver to access these rails via regulator APIs. > > Signed-off-by: Laxman Dewangan > Signed-off-by: Mallikarjun Kasoju > Reviewed-by: Krzysztof Kozlowski > --- > > - Cleanup code based on comment received on mfd/rtc. > - Avoid duplication on error message. > > Changes form V2: > - Run coccicheck and checkpatch in strict mode for the alignment. > - Refactor Regulator driver to use core API for DT parsing. > - Update based on API changes. > > Changes from V3: > - Change all sys initcall to module driver. > - change the max77620_read argument to unisgned int from u8. > > Changes from V4: > - Added DT binding document as devicetree/bindings/regulator/regulator-max77620.txt > - Detail out properties. > > Changes from V5: > - Separate out DT binding doc for regulator. > > Changes from V6: > - Use direct regmap APIs. > - Drop active-discharge configuration as it wil be move to core and through > callback. Follow on patches are palnned for this. > -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755901AbcBIPOE (ORCPT ); Tue, 9 Feb 2016 10:14:04 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:11628 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751197AbcBIPOB (ORCPT ); Tue, 9 Feb 2016 10:14:01 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 09 Feb 2016 07:14:25 -0800 Message-ID: <56B9FF80.7010107@nvidia.com> Date: Tue, 9 Feb 2016 20:32:24 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: , , , , , , , , , , CC: , , , , , , , , , Mallikarjun Kasoju Subject: Re: [PATCH V7 8/8] regulator: max77620: add regulator driver for max77620/max20024 References: <1454171931-27752-1-git-send-email-ldewangan@nvidia.com> <1454171931-27752-9-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1454171931-27752-9-git-send-email-ldewangan@nvidia.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, I have taken care of all your previous comment on this patch. Can you please review? I got the macro from Lee's and spinning the V8 of this series so if there is any thing, I can take care on my next version. Thanks, Laxman On Saturday 30 January 2016 10:08 PM, Laxman Dewangan wrote: > MAXIM Semiconductor's PMIC, MAX77620 and MAX20024 have the > multiple DCDC and LDOs. This supplies the power to different > components of the system. > Also these rails has configuration for ramp time, flexible > power sequence, slew rate etc. > > Add regulator driver to access these rails via regulator APIs. > > Signed-off-by: Laxman Dewangan > Signed-off-by: Mallikarjun Kasoju > Reviewed-by: Krzysztof Kozlowski > --- > > - Cleanup code based on comment received on mfd/rtc. > - Avoid duplication on error message. > > Changes form V2: > - Run coccicheck and checkpatch in strict mode for the alignment. > - Refactor Regulator driver to use core API for DT parsing. > - Update based on API changes. > > Changes from V3: > - Change all sys initcall to module driver. > - change the max77620_read argument to unisgned int from u8. > > Changes from V4: > - Added DT binding document as devicetree/bindings/regulator/regulator-max77620.txt > - Detail out properties. > > Changes from V5: > - Separate out DT binding doc for regulator. > > Changes from V6: > - Use direct regmap APIs. > - Drop active-discharge configuration as it wil be move to core and through > callback. Follow on patches are palnned for this. >