From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 1/3] KVM: APIC: remove unnecessary double checks on APIC existence Date: Tue, 9 Feb 2016 16:06:17 +0100 Message-ID: <56BA0069.30606@redhat.com> References: <1454948146-35353-1-git-send-email-pbonzini@redhat.com> <1454948146-35353-2-git-send-email-pbonzini@redhat.com> <20160209135502.GA30378@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: In-Reply-To: <20160209135502.GA30378@potion.brq.redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 09/02/2016 14:55, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > This is most likely going to bug on the following path: > handle_apic_access -> kvm_lapic_set_eoi >=20 > Before the change, handle_apic_access would just drop EOIs that shoul= d > have gone to user space ... I'm not sure if we tested it, or the path= is > really never taken. cpu_need_virtualize_apic_accesses is needed to set SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES (vmx_secondary_exec_control) an= d SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES is required to get to handle_apic_access. Paolo