From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 2/3] KVM: x86: consolidate "has lapic" checks into irq.c Date: Tue, 9 Feb 2016 16:07:48 +0100 Message-ID: <56BA00C4.4040108@redhat.com> References: <1454948146-35353-1-git-send-email-pbonzini@redhat.com> <1454948146-35353-3-git-send-email-pbonzini@redhat.com> <20160209140543.GB30378@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: In-Reply-To: <20160209140543.GB30378@potion.brq.redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 09/02/2016 15:05, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > 2016-02-08 17:15+0100, Paolo Bonzini: >> Do for kvm_cpu_has_pending_timer and kvm_inject_pending_timer_irqs >> what the other irq.c routines have been doing. >> >> Signed-off-by: Paolo Bonzini >> --- >> diff --git a/arch/x86/kvm/irq.c b/arch/x86/kvm/irq.c >> @@ -33,7 +33,10 @@ >> */ >> int kvm_cpu_has_pending_timer(struct kvm_vcpu *vcpu) >> { >> - return apic_has_pending_timer(vcpu); >> + if (lapic_in_kernel(vcpu)) >> + return apic_has_pending_timer(vcpu); >> + >> + return true; >=20 > Apart from int/bool mismatch, it returned 0 before and that was corre= ct. >=20 So that means "return 0;" implies "Reviewed-by"? :) Paolo