From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTABO-0004xJ-Sq for qemu-devel@nongnu.org; Tue, 09 Feb 2016 10:26:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTABL-0006YT-DW for qemu-devel@nongnu.org; Tue, 09 Feb 2016 10:26:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTABL-0006YP-8T for qemu-devel@nongnu.org; Tue, 09 Feb 2016 10:26:23 -0500 References: <1455012999-26858-1-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <56BA051D.6020107@redhat.com> Date: Tue, 9 Feb 2016 08:26:21 -0700 MIME-Version: 1.0 In-Reply-To: <1455012999-26858-1-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LsW4RIWIQBDDfp9tVRC2cQSim8mKQgXqT" Subject: Re: [Qemu-devel] [PATCH 1/2] migration: move bdrv_invalidate_cache_all of of coroutine context List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Amit Shah , Paolo Bonzini , qemu-devel@nongnu.org, Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LsW4RIWIQBDDfp9tVRC2cQSim8mKQgXqT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/09/2016 03:16 AM, Denis V. Lunev wrote: When sending a 2-patch series, please include a 0/2 cover letter. The only time a cover letter is not necessary is for a single patch. > There is a possibility to hit assert qcow2_get_specific_info that > s->qcow_version is undefined. This happens when VM in starting from > suspended state, i.e. it processes incoming migration, and in the same > time 'info block' is called. >=20 > The problem is that in the qcow2_invalidate_cache closes and the image > and memsets BDRVQcowState in the middle. Grammar; I suggest: The problem is that qcow2_invalidate_cache() closes the image and memset()s BDRVQcowState in the middle. >=20 > The patch moves out processing of bdrv_invalidate_cache_all out of s/moves out/moves/ > coroutine context for standard migration to avoid that. >=20 > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Juan Quintela > CC: Amit Shah > --- > migration/migration.c | 89 ++++++++++++++++++++++++++++---------------= -------- > 1 file changed, 49 insertions(+), 40 deletions(-) >=20 I'll leave the migration experts to give a positive review, but I didn't see anything obviously wrong in the refactor. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LsW4RIWIQBDDfp9tVRC2cQSim8mKQgXqT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWugUeAAoJEKeha0olJ0NqlO4H/iuM5YKsyLCIr3uVBe6PVwUM Un/ezHdqbv/JSvc4iTyZH8EbNfY9nAfEbdGwQv37nhqRxL4WA+zURxSNeMZUd9oZ FVoK29T4/xZzrDqeoKgF3b5iX2Akvpq43aU1h6buWromV434M1v8MArDdqTZekBL HD+aM5FQVHLLYC5PZaKZMphJ8OuAHIXG0yxl05usZ+PJwq8JNU9OvR1inkqFaPVo FEJ3sXcKmQHL2RL3PxM0Yz30bULtly4XMQpqniFdJE+uP5zCuIfnFA5ONeDaY63t ETV/MrWiJ/C3HS3h+w2A6YTPydrwgiPEuIRG7JihHstl4wah2UpocrKs4+DO+i0= =mLNJ -----END PGP SIGNATURE----- --LsW4RIWIQBDDfp9tVRC2cQSim8mKQgXqT--