From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTALG-0006Ek-8Q for qemu-devel@nongnu.org; Tue, 09 Feb 2016 10:36:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTALF-0002Dm-CP for qemu-devel@nongnu.org; Tue, 09 Feb 2016 10:36:38 -0500 References: <7bfce913f68d95284746e7cf3693703f5361b26f.1454940776.git.berto@igalia.com> From: Eric Blake Message-ID: <56BA077F.3040507@redhat.com> Date: Tue, 9 Feb 2016 08:36:31 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RnaFUtUGCGkQq5qOVknhqbjBxOQaD78Kd" Subject: Re: [Qemu-devel] [PATCH 2/3] iotests: Update test 139 after the changes in x-blockdev-del List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RnaFUtUGCGkQq5qOVknhqbjBxOQaD78Kd Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/08/2016 07:14 AM, Alberto Garcia wrote: > Now that we allow x-blockdev-del to work in a new scenario that > previously forbidden we must update the iotests in order to reflect > this change. >=20 > Both testAttachMedia() and testSnapshot() are splitted in two: one s/splitted/split/ (one of those weird English words whose past tense is identical to present tense) > version keeps the previous behavior, and a second version checks that > the new functionality works as expected. >=20 > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/139 | 30 +++++++++++++++++++++++++----- > tests/qemu-iotests/139.out | 4 ++-- > 2 files changed, 27 insertions(+), 7 deletions(-) Does the test fail if 1/3 is applied in isolation? If so, then this patch must be squashed with that one. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --RnaFUtUGCGkQq5qOVknhqbjBxOQaD78Kd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWugd/AAoJEKeha0olJ0NqHdsH/2W5n+C3EGsOetsOdPZkNDFd FhofrbGI14XWkvypNk7Yw6Fg0TrPlygN0WuyY6GQuLN2/IUqEVSXdzbFPB3lGNhG tp9Utm48Nz1lXWubK1oAnSumWpRcZwRQZMoxtrPEgtgGpVKgI8OH/4NoTAFR1LTp 0DHmIVCvuAJZBAXlEx2Du3SbvzitQRvoqYwv2T0lcIMkVNP47k/v2VM8HfE2TdBH ma2kVxwnONNH+JBQYshCQ5YSqT448kOTrYgsQ6/4JCMGKFo6+xhW+Ykt85VfSnom NHoZQtuul8Kp0EpTrh2lXf/dqkUsc2f2H4IzICpxHu3O3mSePDQNkGfNNrmBPSg= =WVnp -----END PGP SIGNATURE----- --RnaFUtUGCGkQq5qOVknhqbjBxOQaD78Kd--