From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTCyz-0004xy-9M for qemu-devel@nongnu.org; Tue, 09 Feb 2016 13:25:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTCyy-0004EF-6A for qemu-devel@nongnu.org; Tue, 09 Feb 2016 13:25:49 -0500 Received: from mail-pa0-x234.google.com ([2607:f8b0:400e:c03::234]:33016) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTCyx-0004Dj-V3 for qemu-devel@nongnu.org; Tue, 09 Feb 2016 13:25:48 -0500 Received: by mail-pa0-x234.google.com with SMTP id cy9so95252653pac.0 for ; Tue, 09 Feb 2016 10:25:47 -0800 (PST) References: <1455020010-17532-1-git-send-email-clg@fr.ibm.com> From: Corey Minyard Message-ID: <56BA2F29.8010109@mvista.com> Date: Tue, 9 Feb 2016 12:25:45 -0600 MIME-Version: 1.0 In-Reply-To: <1455020010-17532-1-git-send-email-clg@fr.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 0/8] ipmi: a couple of enhancements to the BMC simulator (round 2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Cc: Greg Kurz , qemu-devel@nongnu.org, "Michael S. Tsirkin" On 02/09/2016 06:13 AM, Cédric Le Goater wrote: > The first patches are cleanups and prepare ground for an extension of > the BMC simulator providing a SDR loader using a file. A simple FRU > support comes next. > > The last patches introduce APIs to populate a guest device tree with > the available sensors and to generate events, which is needed by > platforms in some occasions. > I have reviewed all of these, and they look good. I only have one comment: The naming of the properties probably needs to be fixed. "sdr" should be "sdrfile" to be consistent with everything else. Technically, a "FRU" is a piece of hardware that can be replaced in the field, "FRU data" is the data describing that FRU, and a "FRU area" is the memory used to store FRU data. I know this is mixed up a lot (and I have done so) but some people are picky about this. With the renaming of sdr (fru is your option): Acked-by: Corey Minyard for all patches. Oh, and I assume you need to add documentation for the properties to qemu-options.hx. -corey > Based on e4a096b1cd43 and also available here : > > https://github.com/legoater/qemu/commits/ipmi > > Thanks, > > C. > > Cédric Le Goater (8): > ipmi: add a realize function to the device class > ipmi: use a function to initialize the SDR table > ipmi: remove the need of an ending record in the SDR table > ipmi: add some local variables in ipmi_sdr_init > ipmi: use a file to load SDRs > ipmi: provide support for FRUs > ipmi: introduce an ipmi_bmc_sdr_find() API > ipmi: introduce an ipmi_bmc_gen_event() API > > hw/ipmi/ipmi_bmc_sim.c | 256 +++++++++++++++++++++++++++++++++++++++++++------ > include/hw/ipmi/ipmi.h | 4 + > 2 files changed, 233 insertions(+), 27 deletions(-) >