From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Long Subject: Re: [PATCH v3 0/2] Consolidate redundant register/stack access code Date: Tue, 9 Feb 2016 15:55:02 -0500 Message-ID: <56BA5226.3090105@linaro.org> References: <1454996337-7935-1-git-send-email-dave.long@linaro.org> <1455010600.13384.3.camel@ellerman.id.au> <20160209094526.GB25268@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=FTJBNCP89X4jorTaKX2DV+OFiXQIhndJKEzGjwF7SdU=; b=PhZ6WQsVdS35e+j+FB0yTnPZ+wg3AszTMQb54rVh4e1xEUMOfi05xVInyMCZFv+yLQ kxho6bZWwLeqmroXsVDZoMCGi15eyBVtPCxrr44tw3Eah5gJqsqntHKi5WDUF2b0XWTe 89mXI2xRCbyEgsQrEflW4nLzgHeV7Za+tJ0rY= In-Reply-To: <20160209094526.GB25268@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Ingo Molnar , Michael Ellerman Cc: Andrew Morton , "H. Peter Anvin" , "chengang@emindsoft.com.cn" , Andy Lutomirski , Benjamin Herrenschmidt , Borislav Petkov , Brian Gerst , David Hildenbrand , Denys Vlasenko , Heiko Carstens , Hendrik Brueckner , Ingo Molnar , Jan Beulich , Kees Cook , Martin Schwidefsky , Oleg Nesterov , Paul Mackerras , Rashmica Gupta , Rich Felker , Richard Kuo , Roland McGrath , Russell King , Thomas Gleixner On 02/09/2016 04:45 AM, Ingo Molnar wrote: > > * Michael Ellerman wrote: > >> On Tue, 2016-02-09 at 00:38 -0500, David Long wrote: >> >>> From: "David A. Long" >>> >>> Move duplicate and functionally equivalent code for accessing registers >>> and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into >>> common kernel files. >>> >>> I'm sending this out again (with updated distribution list) because v2 >>> just never got pulled in, even though I don't think there were any >>> outstanding issues. >> >> A big cross arch patch like this would often get taken by Andrew Morton, but >> AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for >> us :D > > The other problem is that the second patch is commingling changes to 6 separate > architectures: > > 16 files changed, 106 insertions(+), 343 deletions(-) > > that should probably be 6 separate patches. Easier to review, easier to bisect to, > easier to revert, etc. > > Thanks, > > Ingo > I see your point but I'm not sure it could have been broken into separate successive patches that would each build for all architectures. -dl From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Long Date: Tue, 09 Feb 2016 20:55:02 +0000 Subject: Re: [PATCH v3 0/2] Consolidate redundant register/stack access code Message-Id: <56BA5226.3090105@linaro.org> List-Id: References: <1454996337-7935-1-git-send-email-dave.long@linaro.org> <1455010600.13384.3.camel@ellerman.id.au> <20160209094526.GB25268@gmail.com> In-Reply-To: <20160209094526.GB25268@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 02/09/2016 04:45 AM, Ingo Molnar wrote: > > * Michael Ellerman wrote: > >> On Tue, 2016-02-09 at 00:38 -0500, David Long wrote: >> >>> From: "David A. Long" >>> >>> Move duplicate and functionally equivalent code for accessing registers >>> and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into >>> common kernel files. >>> >>> I'm sending this out again (with updated distribution list) because v2 >>> just never got pulled in, even though I don't think there were any >>> outstanding issues. >> >> A big cross arch patch like this would often get taken by Andrew Morton, but >> AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for >> us :D > > The other problem is that the second patch is commingling changes to 6 separate > architectures: > > 16 files changed, 106 insertions(+), 343 deletions(-) > > that should probably be 6 separate patches. Easier to review, easier to bisect to, > easier to revert, etc. > > Thanks, > > Ingo > I see your point but I'm not sure it could have been broken into separate successive patches that would each build for all architectures. -dl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qg0-x236.google.com (mail-qg0-x236.google.com [IPv6:2607:f8b0:400d:c04::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 7BFC31A03A7 for ; Wed, 10 Feb 2016 07:55:07 +1100 (AEDT) Received: by mail-qg0-x236.google.com with SMTP id y89so75900952qge.2 for ; Tue, 09 Feb 2016 12:55:07 -0800 (PST) Subject: Re: [PATCH v3 0/2] Consolidate redundant register/stack access code To: Ingo Molnar , Michael Ellerman References: <1454996337-7935-1-git-send-email-dave.long@linaro.org> <1455010600.13384.3.camel@ellerman.id.au> <20160209094526.GB25268@gmail.com> Cc: Andrew Morton , "H. Peter Anvin" , "chengang@emindsoft.com.cn" , Andy Lutomirski , Benjamin Herrenschmidt , Borislav Petkov , Brian Gerst , David Hildenbrand , Denys Vlasenko , Heiko Carstens , Hendrik Brueckner , Ingo Molnar , Jan Beulich , Kees Cook , Martin Schwidefsky , Oleg Nesterov , Paul Mackerras , Rashmica Gupta , Rich Felker , Richard Kuo , Roland McGrath , Russell King , Thomas Gleixner , Will Deacon , Yoshinori Sato , linux-arm-kernel@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org From: David Long Message-ID: <56BA5226.3090105@linaro.org> Date: Tue, 9 Feb 2016 15:55:02 -0500 MIME-Version: 1.0 In-Reply-To: <20160209094526.GB25268@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 02/09/2016 04:45 AM, Ingo Molnar wrote: > > * Michael Ellerman wrote: > >> On Tue, 2016-02-09 at 00:38 -0500, David Long wrote: >> >>> From: "David A. Long" >>> >>> Move duplicate and functionally equivalent code for accessing registers >>> and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into >>> common kernel files. >>> >>> I'm sending this out again (with updated distribution list) because v2 >>> just never got pulled in, even though I don't think there were any >>> outstanding issues. >> >> A big cross arch patch like this would often get taken by Andrew Morton, but >> AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for >> us :D > > The other problem is that the second patch is commingling changes to 6 separate > architectures: > > 16 files changed, 106 insertions(+), 343 deletions(-) > > that should probably be 6 separate patches. Easier to review, easier to bisect to, > easier to revert, etc. > > Thanks, > > Ingo > I see your point but I'm not sure it could have been broken into separate successive patches that would each build for all architectures. -dl From mboxrd@z Thu Jan 1 00:00:00 1970 From: dave.long@linaro.org (David Long) Date: Tue, 9 Feb 2016 15:55:02 -0500 Subject: [PATCH v3 0/2] Consolidate redundant register/stack access code In-Reply-To: <20160209094526.GB25268@gmail.com> References: <1454996337-7935-1-git-send-email-dave.long@linaro.org> <1455010600.13384.3.camel@ellerman.id.au> <20160209094526.GB25268@gmail.com> Message-ID: <56BA5226.3090105@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/09/2016 04:45 AM, Ingo Molnar wrote: > > * Michael Ellerman wrote: > >> On Tue, 2016-02-09 at 00:38 -0500, David Long wrote: >> >>> From: "David A. Long" >>> >>> Move duplicate and functionally equivalent code for accessing registers >>> and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into >>> common kernel files. >>> >>> I'm sending this out again (with updated distribution list) because v2 >>> just never got pulled in, even though I don't think there were any >>> outstanding issues. >> >> A big cross arch patch like this would often get taken by Andrew Morton, but >> AFAICS you didn't CC him - so I just added him, perhaps he'll pick it up for >> us :D > > The other problem is that the second patch is commingling changes to 6 separate > architectures: > > 16 files changed, 106 insertions(+), 343 deletions(-) > > that should probably be 6 separate patches. Easier to review, easier to bisect to, > easier to revert, etc. > > Thanks, > > Ingo > I see your point but I'm not sure it could have been broken into separate successive patches that would each build for all architectures. -dl