From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulpanit Subject: Re: [PATCH v2 3/6] iommu/amd: Introduce amd_iommu_get_num_iommus() Date: Tue, 9 Feb 2016 16:09:01 -0600 Message-ID: <56BA637D.5040106@amd.com> References: <1451672020-2150-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1451672020-2150-4-git-send-email-Suravee.Suthikulpanit@amd.com> <20160107121550.GE19149@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160107121550.GE19149-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org List-Id: iommu@lists.linux-foundation.org Hi Joerg, On 01/07/2016 06:15 AM, Joerg Roedel wrote: > On Fri, Jan 01, 2016 at 12:13:37PM -0600, Suravee Suthikulpanit wrote: >> +int amd_iommu_get_num_iommus(void) >> +{ >> + return amd_iommus_present; >> +} >> +EXPORT_SYMBOL(amd_iommu_get_num_iommus); > > Is this export needed? The perf code can't be build as a module. > > Otherwise it looks good. > Right. I am fixing this in V3 and sending out shortly. Thanks, Suravee From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933203AbcBIWYn (ORCPT ); Tue, 9 Feb 2016 17:24:43 -0500 Received: from mail-by2on0071.outbound.protection.outlook.com ([207.46.100.71]:12288 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932434AbcBIWYm (ORCPT ); Tue, 9 Feb 2016 17:24:42 -0500 Authentication-Results: lists.linux-foundation.org; dkim=none (message not signed) header.d=none;lists.linux-foundation.org; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH v2 3/6] iommu/amd: Introduce amd_iommu_get_num_iommus() To: Joerg Roedel References: <1451672020-2150-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1451672020-2150-4-git-send-email-Suravee.Suthikulpanit@amd.com> <20160107121550.GE19149@8bytes.org> CC: , , , , , From: Suravee Suthikulpanit Message-ID: <56BA637D.5040106@amd.com> Date: Tue, 9 Feb 2016 16:09:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160107121550.GE19149@8bytes.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [58.10.104.205] X-ClientProxiedBy: HKXPR03CA0074.apcprd03.prod.outlook.com (25.163.104.32) To SN1PR12MB0445.namprd12.prod.outlook.com (25.162.105.139) X-MS-Office365-Filtering-Correlation-Id: 9fd6a56c-0dba-4380-b55c-08d3319da7be X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0445;2:YgIw9k3A+Y6AE7QqpoiQQdkZeiy3DIw7Kcn/mfHBK+TyqldVmewCU+rj6oUAVtxXS5QC/zj0C84aYC0M+/fKdvTb4uLR2WpAY1vpKBdl0v3lRkWVLqZWJJnkqbp/waQkyJrjXcbvdNWm7vt/ISpnt8vTAgAUyZ+zVUM2vsWhaFLN3B6OtoOLBowdopeFV2NK;3:sre4ELbc023S708dtEph5cu0jA1Vs2nIrRN3v9Anvi0NBzAWGet5zpAE6LZvlZp4Hbg3H5BSSajIukDAWlHEmtFjXR3CQOCHLwYfOhzg3YCvWFViWrpFQtG8FnVBtxGJ;25:2DCdKm4mG3tPzXz7g7FfPWNZE7P6L1TxHrOsqdxXlWdcMs97R4NdTxTCzMGGzGplya6UDZRokmL56CiJXCgPsNxHyMZBLyef2xPTaEQL7ql8H2fjEfYJPRbcSP7EGDmzU1azK3bfYl8p72kKW6LECauhVepHjFPH+SR6bhdpymrQiAF4c00UEUSGXUKbmrAfBtBMWM6ofwEDoR7APAPUjF6ooT13yFH7hPlK11LryUqRd4t38oZJ2VVG2wv4Z3K8fcjnOvCEBPvZG4QLmJ9M42RO4QRNm1Ekge8VZkIDMWBVEGYfitAHtuF+mgdN1KJq X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0445; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0445;20:0vltMFa9ZZ9dMHowO/vUXLUggQu+sslquWwjFFgoyV3kfsmxklrroZ/fBprHeoV0qhQAROCXqZVAD1MnKEoBXmMeqaJbGZaGVGuWBTWr/7telbh0VWeFRZGHBbwOmCYXQK9Wr8OnAoruxO/0eZRRicRh5ymbU0oXzbHV8ZjGYEliAOdiBS///v7flakELt5miFTHcrep9R612XWUfQSZ2bDLxLFjhuczqllhpstvWbl35Vybt4nxMZ8aQeez7aia2ezdqil4T9oQuPtnxBoZ7v2wOmwig716HyZY4BYzI+b2plzPzccLLbEX8PtZ8YmndCLroACUH7dFess+7xKbo3/BPxACzJQ3kNAUdjfqpooAyUawJBQXSrLbE/XKal3lo/6I+JVcHyItBJ7Eioi+xDlEyHVg2uctUjU24ygf9pAdUr4MoRrULPvVNxCnNNGbn68WL9VoA017ztPkgEVZx+HLD4Yx6A7l37ZMDK5XPoreG9d5dyg9Fpw8T07/6IYg;4:Yz2zkuSaQXICcBWzl20nYdeZ8YPoENlXdX+MrdL7uLphoLgLPl8+aDoUb5jCHG8HHslAzNO8JdUGDcDw4mKR221pILjztCEiShOo0RcRyIUsApNneWkpNok1NLny7zJD2cEK+7h40Nf0qbN9EAVhE0YxbQuedOD8bPHsCu1MVFM7Hp6eEIDPjmQIIlafr/YAcI6S7F3ruJ1oThpk+a8ZFDhRTDPDJkpYz6478Uk5cVDcbe84Iu+ZM/W+oBPu7TWzOmbuGlvEOxK86FdqzLlveC0RhPD4kh+QuVpxo4DPOrVdjQC6DBlaOOAnvpPjZ2OW7AQgP0KHZPHDHkISSjTl60nr/60G9g/LydGFZLbhGCYMOmW7clGbg3dY/mw4B0Ru X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:SN1PR12MB0445;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0445; X-Forefront-PRVS: 08476BC6EF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(979002)(6049001)(6009001)(377454003)(164054003)(479174004)(24454002)(76176999)(65806001)(54356999)(65816999)(50986999)(77096005)(33656002)(87266999)(42186005)(106356001)(87976001)(47776003)(86362001)(64126003)(59896002)(23746002)(2950100001)(36756003)(65956001)(4326007)(66066001)(4001350100001)(117156001)(83506001)(92566002)(3846002)(6116002)(586003)(80316001)(110136002)(2906002)(40100003)(122386002)(50466002)(5001960100002)(230700001)(189998001)(1096002)(5004730100002)(5008740100001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0445;H:[192.168.1.37];FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;SN1PR12MB0445;23:+/34hjjwRFqVF0v2ffScEZ+wNWFjCSVycVyzK?= =?Windows-1252?Q?abcMpB8Z2eOXBeje2SUY9RoUU6r4Aqz0AGYtCaGJ7B2uWTwOwlAuRr7Y?= =?Windows-1252?Q?4aMgIRR7smxtI3/3NE+aB0i1jiK9gll4QLKmVmIACNKCfsRZvsTbW3Xj?= =?Windows-1252?Q?JXDcw01mMSNPw9fh92EoL6fF9KI59xmrS5rvxNmOX2f5K6nT/kRozuxt?= =?Windows-1252?Q?Mqb9SD1FG/xGcUYuOH/apKmzgcJ3EGbsIfW/8j9ptK4T9iSQUek7LroJ?= =?Windows-1252?Q?A+GqWviu2qHwxbjiwepwNIIqCWRuGmyJVgFQ84YGUtHpBibpA7QzXchs?= =?Windows-1252?Q?QkdPjnoGMnPKLm/ugAK66UuaE6dFeyTxb7vUfH7hr3ueox8ypaw3MWv2?= =?Windows-1252?Q?RJkxIX3SbRfZV2LLO1nt+tEk2uPMaZbkMHWnhJ7ETWOkO1MkPJBKDVJ7?= =?Windows-1252?Q?S3S3Asvia7fusdI5qSLelcfQqLLTT27UdCCvCNqW918ipGg/VkZbhSo9?= =?Windows-1252?Q?EOlefoBnN2lYWhY+PPxo5mg4QOWnU/xm2/Hf3u3Djcg4lzsQUsVLD5qH?= =?Windows-1252?Q?m2FcaD+hKEXdEZkvK857KgOo2YiFz55aFiQB+EtrhfNEFiCdNxP3ee5Q?= =?Windows-1252?Q?mVJ1GctYUFCfq8oRcdf4WLP7fm5JYgkW6N5fhmVxiynWy0pJmv6iMz33?= =?Windows-1252?Q?5830U/CfwVfdvgpcAqiLVexfk1EUMB2iqvXCKc3l/HMtkMKfNcG4qAHl?= =?Windows-1252?Q?Xj7OubWu5pSOjgYYVFpz8GwsGv53QX+w4XHz4v4JzGIX7kuPSQefK4eb?= =?Windows-1252?Q?F7QEAxJijHoF1pG4cwaEbmhw8fUXLsD/coAWbQrr2m+QF1b2RJunbg6/?= =?Windows-1252?Q?5ikSaO48zjQxPhL2U342VVp0/PcgCaa4kTDgKaUb54v1IOyNaXgt/QVX?= =?Windows-1252?Q?JfSFSsZgcfIhF/xToQ2XEB94PESm+mjzDD0qcjg+XQFqfYjH7Mr7qESa?= =?Windows-1252?Q?tEwzYrU9nfQMTVcgwcIv5nYsq4ADFzvVAAP3dxG06qwsZz4UfYd9iRFA?= =?Windows-1252?Q?pwhYj8oeTXOn6R/+jWd9m9Wg8OKaSwcG0HWEkWQSK/WT/wwEdGaI1v8M?= =?Windows-1252?Q?EI64kLtXaGnRwD9MWTRVDTNTNtU+/8W3MLAvLeWyPjPkVstGORX6csO5?= =?Windows-1252?Q?1HcjCLY+OL3PIGy5Bl2XqiHCML/He8b/W6qbLpuIRJMM05FQcmn+1K1K?= =?Windows-1252?Q?GVjM+/7+6BWGoMFpadRpKhfbr19z598HulGCGk9NtZK5NAmZJVwwNHbo?= =?Windows-1252?Q?5/NEA1ZUnd66Op1FtXleqF+oVlLJI7E24z3B34mn1nKEVrMe6a8/tdzP?= =?Windows-1252?Q?g0SefQtyn4RZK25rMormOzr7PSEFoIlkw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0445;5:fsLSHdGVqBdb2P4wMJqCEwhQaY7iNji/463IpgxLrI5BK7qFVXmk3GNd0hI1+J9V9FpF4palMnYwumsQwJb4AdCdfHa04wZ1enSIaz1PyuveLEYEweguVwrEoyevMBqm1wTY86ZIhV6XpNbOBx8t9g==;24:iH+TA0pHVRliPGZ+wHLIoPLjzVYjPlxX1kLxXxJg8WlSVSJy+MiVUH0aUZOas5Xyrpgx9Wh/3wQVJV81LIsil97BLxnPi4aZf6JzqTmxS7E=;20:jlpnBEVjvCz4hLUcgQ0RxRz+WpCHQMER+gp6zOekUGmfP/6Fz6OS5ak+473LW6O9wGRYHNXfIR8QyNWcMQX+Qstd+ExTPiogEyOrVbjkuny1EX23zcUXJMvndxXGXlGqaV87zbvc3cO5+zfMVKhCph34RSq+hckMskkUBw8yoUdS+N/NVjbDfYy1k/kFWMcXt2F2yfyyOBMi4COLaRiWRx9V4QBb8BvddVmzcNQ9U84JlxKUsvkn/U/W21V1jcDY SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2016 22:09:16.0947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0445 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joerg, On 01/07/2016 06:15 AM, Joerg Roedel wrote: > On Fri, Jan 01, 2016 at 12:13:37PM -0600, Suravee Suthikulpanit wrote: >> +int amd_iommu_get_num_iommus(void) >> +{ >> + return amd_iommus_present; >> +} >> +EXPORT_SYMBOL(amd_iommu_get_num_iommus); > > Is this export needed? The perf code can't be build as a module. > > Otherwise it looks good. > Right. I am fixing this in V3 and sending out shortly. Thanks, Suravee