From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id C05D9E00CBB; Tue, 9 Feb 2016 16:09:52 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.52 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 883B1E00CB8 for ; Tue, 9 Feb 2016 16:09:51 -0800 (PST) Received: by mail-wm0-f52.google.com with SMTP id c200so6295336wme.0 for ; Tue, 09 Feb 2016 16:09:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=RF6z4Ok1XNUB4VP40HvmAhASKkOV7390oLoIgMfVMuw=; b=ebVkEQz8NOqtTdYGXu/dx+zQwpyS0pLs91ZWO39cmTPAljHvN9JkuA3dPIubeR0hZj Y1+HDgJDmyF+q4Xy9VLOe8gj5Y50avFTu/P1zyqamQx18NXVCFeHLw/XBY1VEHs4yh74 nd5S0RR8aSdW9naIkL+Piy81Z7Pm3DkDGwO5kBFmtx8NIFNnpgp8Cp6HlnPUEMN6lLHN 9FFpoqNMAlpNZZ4L1B7A6NS5OU0CoNimLSzMVos7+NRUIj81evUBBJjkxbhJ4Ep6G3BU QhU6t8Hko/GCdHQmTITn9OkVs4ZTmYSM6fcg1k6DeTYu9d5hNhpCMEyF7torohZDryh2 q3wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=RF6z4Ok1XNUB4VP40HvmAhASKkOV7390oLoIgMfVMuw=; b=RHPDeZ4Y5K2UQ5/Eh6nIhMoBdgGutN/psOQMhd9gkS9CiD4z/imE3aMOqT/LX1Liwr uoVScp5KBwiw01mQtV9w95Mn9B0ZH7WfYAP+BMMJD9fumBw5NZbv/eVFXLc4C3of2YM2 0jOKv9W/e2UkDj7iePoiSHIWc5knj0t5uu+Ws8Pd0mxuj3bZzjjqke5HJcY/xGNu8mcY sjLIKH/XOE/g6YRrx1a65TyM0X3npmaH2oLsuaep20uct59PVSDtF+22iHiDmx58Z//5 iQhuMlio9TbA59aY3tAFK7LzTsRLSCjC9B/3KqPDHNu3/0CdBZbxjys/0w9++5bktcto nXwQ== X-Gm-Message-State: AG10YOTgo/PWXBs/xD5RlaLAeSm3+2rjVP37mCH3sUQDDOuITQ13im7QdlL0Z+0Bizvyyqg9 X-Received: by 10.28.91.83 with SMTP id p80mr8202228wmb.48.1455062990237; Tue, 09 Feb 2016 16:09:50 -0800 (PST) Received: from [192.168.0.44] (host86-163-126-178.range86-163.btcentralplus.com. [86.163.126.178]) by smtp.googlemail.com with ESMTPSA id x186sm19713285wmg.19.2016.02.09.16.09.49 for (version=TLSv1/SSLv3 cipher=OTHER); Tue, 09 Feb 2016 16:09:49 -0800 (PST) To: toaster@yoctoproject.org References: <1454929191-60078-1-git-send-email-belen.barros.pena@linux.intel.com> From: Michael Wood Message-ID: <56BA7FCC.9010000@intel.com> Date: Wed, 10 Feb 2016 00:09:48 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454929191-60078-1-git-send-email-belen.barros.pena@linux.intel.com> Subject: Re: [review-request] [PATCH] toaster: make build data breadcrumb consistent X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2016 00:09:52 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Thanks - submitted upstream & toaster-next On 08/02/16 10:59, Belen Barros Pena wrote: > From: Belen Barros Pena > > The pages in the build data section of Toaster showed different > breadcrumbs: in some pages the machine was displayed, but not in others. > For builds with more than one target, some pages showed the first > alphabetical target (the correct behaviour), others didn't. > > This patch removes the inconsistencies, showing exactly the same > breacrumb across all pages in the section. > > The patch also removes the extra space between the '+' and the number of > targets when the builds have more than one target. > > Signed-off-by: Belen Barros Pena > --- > bitbake/lib/toaster/toastergui/templates/basebuilddetailpage.html | 2 +- > bitbake/lib/toaster/toastergui/templates/basebuildpage.html | 2 +- > bitbake/lib/toaster/toastergui/templates/builddashboard.html | 3 +-- > 3 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/bitbake/lib/toaster/toastergui/templates/basebuilddetailpage.html b/bitbake/lib/toaster/toastergui/templates/basebuilddetailpage.html > index 22ca50c..ffe7aa4 100644 > --- a/bitbake/lib/toaster/toastergui/templates/basebuilddetailpage.html > +++ b/bitbake/lib/toaster/toastergui/templates/basebuilddetailpage.html > @@ -8,7 +8,7 @@ > >