From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id A82EDE00CBB; Tue, 9 Feb 2016 16:11:39 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.52 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id AF1E2E00CB8 for ; Tue, 9 Feb 2016 16:11:38 -0800 (PST) Received: by mail-wm0-f52.google.com with SMTP id c200so6333245wme.0 for ; Tue, 09 Feb 2016 16:11:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=Niu6d3/MyJD9I++eun+W6Jee8nEydxO6HcFkDnoRy5w=; b=vBh+Rh3lyO8lrEpJW+L8Boo6dKDKB9lzZM6mMsxhJKTLKg40sV3RceMo3kTYoSLAKr BDyZZx2QkcQcztiyuUHqrerFrryDIEuXlCqljnCcmsXpLBK0QYGQAsekNHXmnhuHNOr3 xF9EscTdPjq6+iOaqkApng8WXKo6IuS+4UYPjUBfKbFBHL6dFyKR43yW9gr1q69nRYho r5yuzlSmSZg34Eb10DMDk/NgnzoKkuMR1C3D0HDatu086MpbW5WtvVvkmDBj6kTd5t7D Xl4u5MkXJlFQuKQrYoF8O/RtOycF5BfFhUy+kvv440pQCX5sLoPqY1u+V+HgFCRUPXRp FrEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=Niu6d3/MyJD9I++eun+W6Jee8nEydxO6HcFkDnoRy5w=; b=BhJxxAF/UyzuHqjpIOg9sQn/RsSbF4cm+AsgraCoFO0wFBtXlZsPSgh02nYmDcO/Yd ji61opfXFf4+M+jAgfTO7ocxjcFce0UYou9yhAnSjri4n+bLaHWmBYnSs6yV2TtIMk+c coUuIw0BT+ZnBpXT7MbTljLYEHb30tZqADbB2HEeGoVkPMkbOipscJDqXf2oVaturdPV iuIT3w5gGyXw/4f4AXYI1tpZSmm+6M2weXvljzLub1TKPm5X01N5uxkFCO22pIfx4diY G9r7dkcZDzjkpEc3CSzb2M6v54m+jCUNCsNn/fJlzKSdGgVE0P7Myzd4DaocgdpGJCDO DuJQ== X-Gm-Message-State: AG10YORQdZCjSZtU8hztVPQffcPWO4mPTzQ4mK/dZY7MrT6grs2lWS5VL0hkFhBbO1ux4e0h X-Received: by 10.28.213.142 with SMTP id m136mr8063846wmg.24.1455063097734; Tue, 09 Feb 2016 16:11:37 -0800 (PST) Received: from [192.168.0.44] (host86-163-126-178.range86-163.btcentralplus.com. [86.163.126.178]) by smtp.googlemail.com with ESMTPSA id v66sm853833wmb.18.2016.02.09.16.11.36 for (version=TLSv1/SSLv3 cipher=OTHER); Tue, 09 Feb 2016 16:11:37 -0800 (PST) To: toaster@yoctoproject.org References: <1454943946-62659-1-git-send-email-belen.barros.pena@linux.intel.com> From: Michael Wood Message-ID: <56BA8034.607@intel.com> Date: Wed, 10 Feb 2016 00:11:32 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454943946-62659-1-git-send-email-belen.barros.pena@linux.intel.com> Subject: Re: [PATCH] toaster: improve display of builds with more than one target X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2016 00:11:39 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Thanks submitted upstream and toaster-next with a small change to help initialise other tooltips properly instead of having to have a new class: + /* Initialise bootstrap tooltips */ + $(".get-help, [data-toggle=tooltip]").tooltip({ + container : 'body', + html : true, + delay: { show : 300 } + }); On 08/02/16 15:05, Belen Barros Pena wrote: > From: Belen Barros Pena > > * Display always the first target in alphabetical order to match what we > do in the breadcrumbs and the build dashboard heading > > * Remove the extra space between the '+' and the additional number of targets > > * Make sure the tooltip with the full target list takes the Bootstrap > tooltip styles > > * Replace the word 'targets' in the tooltip with 'recipes', since that's > how we call build targets everywhere else in Toaster > > Signed-off-by: Belen Barros Pena > --- > bitbake/lib/toaster/toastergui/static/js/libtoaster.js | 4 ++-- > bitbake/lib/toaster/toastergui/templates/mrb_section.html | 13 +++++++------ > 2 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/bitbake/lib/toaster/toastergui/static/js/libtoaster.js b/bitbake/lib/toaster/toastergui/static/js/libtoaster.js > index 1012034..e2dba48 100644 > --- a/bitbake/lib/toaster/toastergui/static/js/libtoaster.js > +++ b/bitbake/lib/toaster/toastergui/static/js/libtoaster.js > @@ -443,8 +443,8 @@ $(document).ready(function() { > $('.tooltip').hide(); > }); > > - // enable help information tooltip > - $(".get-help").tooltip({container:'body', html:true, delay:{show:300}}); > + // enable help information and multi target build tooltips > + $(".get-help, .multitarget-build").tooltip({container:'body', html:true, delay:{show:300}}); > > // show help bubble only on hover inside tables > $(".hover-help").css("visibility","hidden"); > diff --git a/bitbake/lib/toaster/toastergui/templates/mrb_section.html b/bitbake/lib/toaster/toastergui/templates/mrb_section.html > index 2f4820c..758a76c 100644 > --- a/bitbake/lib/toaster/toastergui/templates/mrb_section.html > +++ b/bitbake/lib/toaster/toastergui/templates/mrb_section.html > @@ -36,10 +36,11 @@ > > {% endif %} > {% if build.target_set.all.count > 0 %} > - + {% if build.target_set.all.count > 1 %} > - title="Targets: > - {% for target in build.target_set.all %} > + {{build.get_sorted_target_list.0.target}} > + title="Recipes: > + {% for target in build.get_sorted_target_list %} > {% if target.task %} > {{target.target}}:{{target.task}} > {% else %} > @@ -49,12 +50,12 @@ > {% endif %} > > > {% if build.target_set.all.0.task %} > - {{build.target_set.all.0.target}}:{{build.target_set.all.0.task}} > + {{build.get_sorted_target_list.0.target}}:{{build.target_set.all.0.task}} > {% else %} > - {{build.target_set.all.0.target}} > + {{build.get_sorted_target_list.0.target}} > {% endif %} > {% if build.target_set.all.count > 1 %} > - (+ {{build.target_set.all.count|add:"-1"}}) > + (+{{build.target_set.all.count|add:"-1"}}) > {% endif %} > > {% endif %}