From: Gustavo Zacarias <gustavo.zacarias@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] linux: add conditional patch for timeconst.pl
Date: Tue, 9 Feb 2016 22:27:17 -0300 [thread overview]
Message-ID: <56BA91F5.9050202@free-electrons.com> (raw)
In-Reply-To: <56BA863D.3030600@mind.be>
On 09/02/16 21:37, Arnout Vandecappelle wrote:
> Well, you're already duplicating code because you first to patch and then
> APPLY_PATCHES. My idea was something like:
>
> $(Q)cd $(@D); patch -p1 -f -s >/dev/null 2>&1 \
> < $(LINUX_PKGDIR)/0001-timeconst.pl-Eliminate-Perl-warning.patch.conditional \
> && echo 0001-timeconst.pl-Eliminate-Perl-warning.patch.conditional >
> .applied_patches_list
>
> But really it's equally hacky so it doesn't matter much. Actually, my version
> is especially hacky because it relies on the fact that the patch has a single
> hunk so it will always pass or fail atomically.
Remember that this will leave a reject file behind for the case where
the kernel is already patched (few releases, but still...)
> I considered that as well, like making it handle *.conditional this way. But
> since this is the only patch for the time being, it's a bit redundant...
>
>
> Bottom line: keep it as it is.
If the need arises with one or two more patches like this then yes, we
can add some *.patch.maybe logic (personally i wouldn't call it
conditional since a condition must be met, though 'maybe' sucks as well).
Regards.
next prev parent reply other threads:[~2016-02-10 1:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-07 13:41 [Buildroot] [PATCH v2] linux: add conditional patch for timeconst.pl gustavo.zacarias at free-electrons.com
2016-02-07 14:50 ` Thomas Petazzoni
2016-02-09 23:08 ` Arnout Vandecappelle
2016-02-09 23:19 ` Gustavo Zacarias
2016-02-10 0:37 ` Arnout Vandecappelle
2016-02-10 1:27 ` Gustavo Zacarias [this message]
2016-02-10 7:11 ` Peter Korsgaard
2016-02-10 7:12 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BA91F5.9050202@free-electrons.com \
--to=gustavo.zacarias@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.