Re: [PATCH] iproute2: enable previously unselected utilities

[Randy MacLeod <randy.macleod@windriver.com>]

On 2015-12-01 12:58 AM, Maxin B. John wrote:
> Hi,
>
> On Tue, Dec 01, 2015 at 01:29:43AM -0800, Khem Raj wrote:
>> On Tue, Dec 1, 2015 at 1:27 AM, Anders Darander <anders@chargestorm.se> wrote:
>>> Hi,
>>>
>>> Just a couple of questions.
>>>
>>> * Maxin B. John <maxin.john@intel.com> [151130 17:59]:
>>>> Include below listed utilities that are not yet enabled/packaged
>>>> in the iproute2 recipe:
>>>
>>>> lnstat
>>>> ifstat
>>>> genl
>>>> rtacct
>>>> nstat
>>>> ss
>>>
>>> When you enable those, how much does the size ofthe iproute2 package
>>> increase?
>>>
>
> The increase in size is around 268K.
>
> $ du -sh iproute2
> 476K    iproute2
>
> $ du -sh iproute2-new
> 744K    iproute2-new
>
>>> Perhaps those extra tools should be placed in e.g. ${PN}-tools, or
>>> some package like that?
>>
>> I think its better to package each one in separate package of its own.
>>
>
> Ok. I will split these binaries in separate packages.

Maxin,

Will you be able to do this as part of the 4.4 upgrade that
you have just sent or would you like Robert to find someone
to do it when he is back from holiday next week?

../Randy
>
>>>
>>> Cheers,
>>> Anders
>>>
>>>> Signed-off-by: Maxin B. John <maxin.john@intel.com>
>>>> ---
>>>>   meta/recipes-connectivity/iproute2/iproute2.inc | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>> diff --git a/meta/recipes-connectivity/iproute2/iproute2.inc b/meta/recipes-connectivity/iproute2/iproute2.inc
>>>> index 29f9062..abaff3f 100644
>>>> --- a/meta/recipes-connectivity/iproute2/iproute2.inc
>>>> +++ b/meta/recipes-connectivity/iproute2/iproute2.inc
>>>> @@ -13,7 +13,7 @@ DEPENDS = "flex-native bison-native iptables elfutils"
>>>
>>>>   inherit update-alternatives
>>>
>>>> -EXTRA_OEMAKE = "CC='${CC}' KERNEL_INCLUDE=${STAGING_INCDIR} DOCDIR=${docdir}/iproute2 SUBDIRS='lib tc ip' SBINDIR='${base_sbindir}' LIBDIR='${libdir}'"
>>>> +EXTRA_OEMAKE = "CC='${CC}' KERNEL_INCLUDE=${STAGING_INCDIR} DOCDIR=${docdir}/iproute2 SUBDIRS='lib tc ip misc genl' SBINDIR='${base_sbindir}' LIBDIR='${libdir}'"
>>>
>>>>   do_configure_append () {
>>>>       sh configure ${STAGING_INCDIR}
>>> --
>>> Anders Darander, Senior System Architect
>>> ChargeStorm AB / eStorm AB
>>> --
>
> Best Regards,
> Maxin
>


-- 
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, 
Canada, K2K 2W5