From: "David Müller (ELSOFT AG)" <d.mueller@elsoft.ch>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] arm: make sure board_init_r() is being called using the right mode (ARM / THUMB)
Date: Wed, 10 Feb 2016 08:57:38 +0100 [thread overview]
Message-ID: <56BAED72.9090901@elsoft.ch> (raw)
In-Reply-To: <20160209170354.GO11375@bill-the-cat>
Hello
Tom Rini wrote:
> On Tue, Feb 09, 2016 at 04:48:28PM +0100, David M?ller wrote:
>> /* call board_init_r */
>> +#if defined(CONFIG_SYS_THUMB_BUILD)
>> + ldr lr, =board_init_r /* this is auto-relocated! */
>> + bx lr
>> +#else
>> ldr pc, =board_init_r /* this is auto-relocated! */
>> -
>> +#endif
>> /* we should not return here. */
>> #endif
>
> In general, my preference is always to use the thumb compatible way, can
> you rework like that and explain in the commit message? Thanks!
AFAIK, the "bx" instruction is undefined on non-THUMB capable
architectures. I therefore don't see a way to avoid some kind of
#if/#else/#endif construct.
Dave
next prev parent reply other threads:[~2016-02-10 7:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 15:48 [U-Boot] [PATCH 0/4] Use THUMB mode for VCMA9 U-Boot builts David Müller
2016-02-09 15:48 ` [U-Boot] [PATCH 1/4] arm: make sure board_init_r() is being called using the right mode (ARM / THUMB) David Müller
2016-02-09 17:03 ` Tom Rini
2016-02-10 7:57 ` David Müller (ELSOFT AG) [this message]
2016-02-10 22:12 ` Tom Rini
2016-02-15 22:35 ` [U-Boot] [U-Boot, " Tom Rini
2016-02-09 15:48 ` [U-Boot] [PATCH 2/4] arm: the ARM920T is THUMB capable, so select the appropriate ISA David Müller
2016-02-15 22:35 ` [U-Boot] [U-Boot, " Tom Rini
2016-02-09 15:48 ` [U-Boot] [PATCH 3/4] arm: build some file(s) as ARM mode only David Müller
2016-02-15 22:35 ` [U-Boot] [U-Boot,3/4] " Tom Rini
2016-02-09 15:48 ` [U-Boot] [PATCH 4/4] arm: VCMA9: because of NOR flash space constrains, activate THUMB build mode David Müller
2016-02-15 22:35 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BAED72.9090901@elsoft.ch \
--to=d.mueller@elsoft.ch \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.