From: Adrian Hunter <adrian.hunter@intel.com>
To: nicolas.ferre@atmel.com, Ludovic Desroches <ludovic.desroches@atmel.com>
Cc: ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe
Date: Wed, 10 Feb 2016 15:00:09 +0200 [thread overview]
Message-ID: <56BB3459.6090506@intel.com> (raw)
In-Reply-To: <20160210125139.GB14937@odux.rfo.atmel.com>
On 10/02/16 14:51, Ludovic Desroches wrote:
> Hi Adrian,
>
> On Wed, Feb 10, 2016 at 01:50:44PM +0200, Adrian Hunter wrote:
>> On 10/02/16 11:58, Ludovic Desroches wrote:
>>> By putting the device in suspend at the end of the probe, it is
>>> impossible to wake up on non software event such as card
>>> insertion/removal.
>>>
>>> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
>>> ---
>>>
>>> Hi,
>>>
>>> Since I had no feedback on this topic:
>>> http://permalink.gmane.org/gmane.linux.kernel.mmc/35160
>>>
>>> I would like to no more put the device in suspend at the end of the probe. If
>>> my device is suspended at the end of the probe, I have no issue to resume on
>>> a software event such as mounting my sdcard but hardware event such as card
>>> insertion and removal do not trigger a resume.
>>
>> You can't use runtime PM unless you have a way to wake-up.
>>
>
> Thanks for your feedback. I am a bit disappointed since Ulf advised me to use
> runtime PM instead of system PM.
>
>> Currently, sdhci disables card detect interrupts when runtime suspended,
>> and drivers use a card-detect GPIO to wake-up.
>>
>
> It is what I have seen going through the sdhci layer. So next question is:
> is it normal to not take care of card detect interrupts? We keep enabled
> some IRQs probably for SDIO modules IRQ but not for card detection. I
> don't understand the reason.
Does sdhci-of-at91.c generate card detect interrupts while runtime suspended?
next prev parent reply other threads:[~2016-02-10 13:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 9:58 [RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe Ludovic Desroches
2016-02-10 9:58 ` Ludovic Desroches
2016-02-10 11:50 ` Adrian Hunter
2016-02-10 12:51 ` Ludovic Desroches
2016-02-10 12:51 ` Ludovic Desroches
2016-02-10 13:00 ` Adrian Hunter [this message]
2016-02-10 14:16 ` Ludovic Desroches
2016-02-10 14:16 ` Ludovic Desroches
2016-02-10 14:20 ` Adrian Hunter
2016-02-10 15:34 ` Ludovic Desroches
2016-02-10 15:34 ` Ludovic Desroches
2016-02-10 15:56 ` Ulf Hansson
2016-02-11 9:08 ` Ludovic Desroches
2016-02-11 9:46 ` Ulf Hansson
2016-02-11 11:05 ` Ludovic Desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BB3459.6090506@intel.com \
--to=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=nicolas.ferre@atmel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.