All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafaël Carré" <funman@videolan.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-multimedia][PATCH 2/2] vlc: make sdl optional (enabled by default)
Date: Wed, 10 Feb 2016 14:20:43 +0100	[thread overview]
Message-ID: <56BB392B.7000203@videolan.org> (raw)
In-Reply-To: <20160210131946.GB2609@jama>

On 10/02/2016 14:19, Martin Jansa wrote:
> On Wed, Feb 10, 2016 at 01:54:22PM +0100, Rafaël Carré wrote:
>> ---
> 
> Did you forget to add sdl to default PACKAGECONFIG?

Oops yes,

sdl also depends on x11 and I am not sure how to add that dependency:
Something like

	{@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 sdl', '', d)}

?

>>  meta-multimedia/recipes-multimedia/vlc/vlc.inc | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>> index 2887a68..c85a811 100644
>> --- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>> +++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
>> @@ -6,7 +6,7 @@ LICENSE = "GPL-2.0"
>>  LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>>  
>>  DEPENDS = "libfribidi libtool libgcrypt libgcrypt-native \
>> -   virtual/libsdl libsdl-image dbus dbus-glib libxml2 gnutls \
>> +   dbus dbus-glib libxml2 gnutls \
>>     tremor faad2 ffmpeg flac fluidsynth alsa-lib \
>>     lua-native lua libidn \
>>     avahi jpeg xz libmodplug mpeg2dec \
>> @@ -25,7 +25,6 @@ EXTRA_OECONF = "\
>>      --disable-screen --disable-caca \
>>      --enable-httpd --enable-vlm \
>>      --enable-freetype \
>> -    --enable-sdl \ 
>>      --enable-png \
>>      --enable-tremor \
>>      --enable-v4l2 --disable-aa --disable-faad \
>> @@ -41,6 +40,7 @@ EXTRA_OECONF = "\
>>  
>>  PACKAGECONFIG ?= " live555 dc1394 dv1394 notify fontconfig freetype dvdread {@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}"
>>  PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
>> +PACKAGECONFIG[sdl] = "--enable-sdl,--disable-sdl,virtual/libsdl libsdl-image "
>>  PACKAGECONFIG[a52] = "--enable-a52,--disable-a52,liba52"
>>  PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack"
>>  PACKAGECONFIG[live555] = "--enable-live555,--disable-live555,live555"
>> -- 
>> 2.5.0


  reply	other threads:[~2016-02-10 13:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-10 12:54 [meta-multimedia][PATCH 1/2] vlc: make x11 DISTRO_FEATURE optional (enabled by default) Rafaël Carré
2016-02-10 12:54 ` [meta-multimedia][PATCH 2/2] vlc: make sdl " Rafaël Carré
2016-02-10 13:19   ` Martin Jansa
2016-02-10 13:20     ` Rafaël Carré [this message]
2016-02-10 13:25   ` [meta-multimedia][PATCHv2] " Rafaël Carré
2016-03-02 19:24 ` [meta-multimedia][PATCH 1/2] vlc: make x11 DISTRO_FEATURE " Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BB392B.7000203@videolan.org \
    --to=funman@videolan.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.