From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTV08-0000WO-5K for qemu-devel@nongnu.org; Wed, 10 Feb 2016 08:40:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTV04-0001GU-Tk for qemu-devel@nongnu.org; Wed, 10 Feb 2016 08:40:12 -0500 Received: from mx2.suse.de ([195.135.220.15]:58898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTV04-0001F1-NE for qemu-devel@nongnu.org; Wed, 10 Feb 2016 08:40:08 -0500 References: From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <56BB3DB7.4040202@suse.de> Date: Wed, 10 Feb 2016 14:40:07 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] target-arm: Implement DBGDTRRX_EL0/DBGDTRTX_EL0 MSR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Dirk_M=c3=bcller?= , QEMU Developers , Andreas Schwab Cc: Peter Maydell Hi Andreas, Am 09.02.2016 um 21:59 schrieb Dirk M=FCller: > This is used by the ARM JTAG DCC console in the Linux kernel, > but can be ignored in order to continue booting. >=20 > Co-Authored-By: Andreas Schwab If this was co-authored by you, we need a proper Signed-off-by please. > Signed-off-by: Dirk Mueller > --- > target-arm/helper.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/target-arm/helper.c b/target-arm/helper.c > index 954e6e8..abce416 100644 > --- a/target-arm/helper.c > +++ b/target-arm/helper.c > @@ -3704,6 +3704,9 @@ static const ARMCPRegInfo debug_cp_reginfo[] =3D = { > { .name =3D "DBGVCR", > .cp =3D 14, .opc1 =3D 0, .crn =3D 0, .crm =3D 7, .opc2 =3D 0, > .access =3D PL1_RW, .type =3D ARM_CP_NOP }, > + { .name =3D "DBGDTRxX_EL0", .state =3D ARM_CP_STATE_BOTH, > + .cp =3D 14, .opc0 =3D 2, .opc1 =3D 3, .crn =3D 0, .crm =3D 5, .o= pc2 =3D 0, > + .access =3D PL0_RW, .type =3D ARM_CP_NOP }, > REGINFO_SENTINEL > }; > =20 Otherwise this can have my Reviewed-by. The small x was suggested by me since it's actually RX/TX depending on R/W. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC= rnberg)