From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 2/7] xen/x86: merge 2 hvm_event_...
 functions into 1
Date: Wed, 10 Feb 2016 16:37:42 +0000
Message-ID: <56BB6756.8070208@citrix.com>
References: <1455119259-2161-1-git-send-email-czuzu@bitdefender.com>
	<1455119433-2308-1-git-send-email-czuzu@bitdefender.com>
	<56BB710302000078000D0B05@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56BB710302000078000D0B05@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Corneliu ZUZU <czuzu@bitdefender.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Tamas K Lengyel <tamas@tklengyel.com>, Keir Fraser <keir@xen.org>, Razvan Cojocaru <rcojocaru@bitdefender.com>, xen-devel@lists.xen.org, Jun Nakajima <jun.nakajima@intel.com>
List-Id: xen-devel@lists.xenproject.org

On 10/02/16 16:18, Jan Beulich wrote:
>
>> --- a/xen/include/asm-x86/hvm/event.h
>> +++ b/xen/include/asm-x86/hvm/event.h
>> @@ -17,6 +17,12 @@
>>  #ifndef __ASM_X86_HVM_EVENT_H__
>>  #define __ASM_X86_HVM_EVENT_H__
>>  
>> +enum hvm_event_breakpoint_type
>> +{
>> +    HVM_EVENT_SOFTWARE_BREAKPOINT,
>> +    HVM_EVENT_SINGLESTEP_BREAKPOINT,
>> +};
> I don't see what good it does to put existing constants into an
> enum.

An enum was requested during review of v1, because "bool
software_breakpoint" isn't a good function interface.

I don't mind if #defines were used instead, but the parameter should
have a semantic name used in calling code.

~Andrew