From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corneliu ZUZU Subject: Re: [PATCH v2 3/7] xen/vm-events: Move monitor_domctl to common-side. Date: Wed, 10 Feb 2016 19:14:55 +0200 Message-ID: <56BB700F.3020807@bitdefender.com> References: <1455119259-2161-1-git-send-email-czuzu@bitdefender.com> <1455119548-2401-1-git-send-email-czuzu@bitdefender.com> <56BB72B902000078000D0B17@prv-mh.provo.novell.com> <56BB73A802000078000D0B3D@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56BB73A802000078000D0B3D@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Kevin Tian , Tamas K Lengyel , Keir Fraser , Ian Campbell , Razvan Cojocaru , Andrew Cooper , xen-devel@lists.xen.org, Stefano Stabellini , Jun Nakajima List-Id: xen-devel@lists.xenproject.org On 2/10/2016 6:30 PM, Jan Beulich wrote: >>>> On 10.02.16 at 17:26, wrote: >>>>> On 10.02.16 at 16:52, wrote: >>> xen/arch/x86/Kconfig | 4 + >>> xen/arch/x86/Makefile | 2 +- >>> xen/arch/x86/hvm/event.c | 2 +- >>> xen/arch/x86/hvm/hvm.c | 2 +- >>> xen/arch/x86/hvm/vmx/vmx.c | 2 +- >>> xen/arch/x86/monitor_x86.c | 72 ++++++++ >>> xen/common/Kconfig | 20 +++ >>> xen/common/Makefile | 1 + >>> xen/common/domctl.c | 2 +- >>> xen/{arch/x86 => common}/monitor.c | 195 +++++++++------------- >>> xen/include/asm-arm/{monitor.h => monitor_arch.h} | 34 +++- >>> xen/include/asm-x86/monitor_arch.h | 74 ++++++++ >>> xen/include/{asm-x86 => xen}/monitor.h | 17 +- >>> 13 files changed, 293 insertions(+), 134 deletions(-) >>> create mode 100644 xen/arch/x86/monitor_x86.c >>> rename xen/{arch/x86 => common}/monitor.c (44%) >>> rename xen/include/asm-arm/{monitor.h => monitor_arch.h} (46%) >>> create mode 100644 xen/include/asm-x86/monitor_arch.h >>> rename xen/include/{asm-x86 => xen}/monitor.h (74%) >> With percentages as low as 44 I'm not sure all this strange >> renaming and introduction of oddly named new files is actually a >> good idea. > Also it looks like this moving around of files needs to be > accompanied by adjustments to ./MAINTAINERS. > > Jan > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > Will check that, indeed these might have broken something there. Corneliu.