From mboxrd@z Thu Jan  1 00:00:00 1970
From: Corneliu ZUZU <czuzu@bitdefender.com>
Subject: Re: [PATCH v2 4/7] Rename monitor_x86.c to monitor.c
 and monitor_arch.h to monitor.h
Date: Wed, 10 Feb 2016 22:54:56 +0200
Message-ID: <56BBA3A0.4070008@bitdefender.com>
References: <1455119259-2161-1-git-send-email-czuzu@bitdefender.com>
	<1455119657-2494-1-git-send-email-czuzu@bitdefender.com>
	<CABfawh=RD30f3dBeMdkFom3XSnSeFPxEhkRAYm2Zs8G4jzntEw@mail.gmail.com>
	<56BB7E7802000078000D0C4D@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56BB7E7802000078000D0C4D@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Tamas K Lengyel <tamas@tklengyel.com>
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Razvan Cojocaru <rcojocaru@bitdefender.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Xen-devel <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 2/10/2016 7:16 PM, Jan Beulich wrote:
>>>> On 10.02.16 at 17:44, <tamas@tklengyel.com> wrote:
>> On Wed, Feb 10, 2016 at 8:54 AM, Corneliu ZUZU <czuzu@bitdefender.com>
>> wrote:
>>
>>> Rename:
>>>      - arch/x86/monitor_x86.c -> arch/x86/monitor.c
>>>      - asm-{x86,arm}/monitor_arch.h -> asm-{x86,arm}/monitor.h
>>>
>>> (previous commit explains why these renames were necessary)
>>>
>> Referencing a "previous commit" like this is not acceptable as you don't
>> know how these patches will get applied and there might be other patches
>> that get committed in-between yours. In each patch explain clearly why the
>> patch is needed. I still find it odd that you need to rename x86/monitor.c
>> -> x86/monitor_x86.c -> x86/monitor.c in the same series.
> Indeed. Thinking about it again perhaps the operations should be
> "move to common/ (mostly) verbatim" followed by "break out x86
> specific code" (if that's the smaller portion compared to what is to
> stay).
>
> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>

That's a great alternative! Will do so in v3.

Corneliu.