From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bl2on0090.outbound.protection.outlook.com ([65.55.169.90]:12752 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750750AbcBJU4p (ORCPT ); Wed, 10 Feb 2016 15:56:45 -0500 Subject: Re: [PATCH v11 3/4] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi To: , , , , , , , , , , References: <1455037240-16192-1-git-send-email-fu.wei@linaro.org> <1455037240-16192-4-git-send-email-fu.wei@linaro.org> CC: , , , , , , , , , , , , , , , , , , From: Suravee Suthikulpanit Message-ID: <56BBA3F0.4010908@amd.com> Date: Thu, 11 Feb 2016 03:56:16 +0700 MIME-Version: 1.0 In-Reply-To: <1455037240-16192-4-git-send-email-fu.wei@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Hi Fu Wei, On 2/10/16 00:00, fu.wei@linaro.org wrote: > From: Fu Wei > > This can be a example of adding SBSA Generic Watchdog device node > into some dts files for the Soc which contains SBSA Generic Watchdog. > > Acked-by: Arnd Bergmann > Signed-off-by: Suravee Suthikulpanit > Signed-off-by: Fu Wei > --- > arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi > index 2874d92..67eb636 100644 > --- a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi > +++ b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi > @@ -84,6 +84,15 @@ > clock-names = "uartclk", "apb_pclk"; > }; > > + watchdog0: watchdog@e0bb0000 { > + compatible = "arm,sbsa-gwdt"; > + reg = <0x0 0xe0bc0000 0 0x1000>, > + <0x0 0xe0bb0000 0 0x1000>; > + interrupts = <0 337 4>; > + timeout-sec = <15>; > + status = "disabled"; Could you please remove this status line? I do not think it is necessary for this one here anymore. Thanks, Suravee > + }; > + > spi0: ssp@e1020000 { > status = "disabled"; > compatible = "arm,pl022", "arm,primecell"; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee.Suthikulpanit@amd.com (Suravee Suthikulpanit) Date: Thu, 11 Feb 2016 03:56:16 +0700 Subject: [PATCH v11 3/4] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi In-Reply-To: <1455037240-16192-4-git-send-email-fu.wei@linaro.org> References: <1455037240-16192-1-git-send-email-fu.wei@linaro.org> <1455037240-16192-4-git-send-email-fu.wei@linaro.org> Message-ID: <56BBA3F0.4010908@amd.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Fu Wei, On 2/10/16 00:00, fu.wei at linaro.org wrote: > From: Fu Wei > > This can be a example of adding SBSA Generic Watchdog device node > into some dts files for the Soc which contains SBSA Generic Watchdog. > > Acked-by: Arnd Bergmann > Signed-off-by: Suravee Suthikulpanit > Signed-off-by: Fu Wei > --- > arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi > index 2874d92..67eb636 100644 > --- a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi > +++ b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi > @@ -84,6 +84,15 @@ > clock-names = "uartclk", "apb_pclk"; > }; > > + watchdog0: watchdog at e0bb0000 { > + compatible = "arm,sbsa-gwdt"; > + reg = <0x0 0xe0bc0000 0 0x1000>, > + <0x0 0xe0bb0000 0 0x1000>; > + interrupts = <0 337 4>; > + timeout-sec = <15>; > + status = "disabled"; Could you please remove this status line? I do not think it is necessary for this one here anymore. Thanks, Suravee > + }; > + > spi0: ssp at e1020000 { > status = "disabled"; > compatible = "arm,pl022", "arm,primecell"; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulpanit Subject: Re: [PATCH v11 3/4] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi Date: Thu, 11 Feb 2016 03:56:16 +0700 Message-ID: <56BBA3F0.4010908@amd.com> References: <1455037240-16192-1-git-send-email-fu.wei@linaro.org> <1455037240-16192-4-git-send-email-fu.wei@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1455037240-16192-4-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-watchdog-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org, corbet-T1hC0tSOHrs@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linaro-acpi-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, rruigrok-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, harba-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, panand-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, graeme.gregory-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, al.stone-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, hanjun.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, leo.duran-5C7GfCeVMHo@public.gmane.org, sudeep.holla-5wv7dgnIgG8@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Fu Wei, On 2/10/16 00:00, fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org wrote: > From: Fu Wei > > This can be a example of adding SBSA Generic Watchdog device node > into some dts files for the Soc which contains SBSA Generic Watchdog. > > Acked-by: Arnd Bergmann > Signed-off-by: Suravee Suthikulpanit > Signed-off-by: Fu Wei > --- > arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi > index 2874d92..67eb636 100644 > --- a/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi > +++ b/arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi > @@ -84,6 +84,15 @@ > clock-names = "uartclk", "apb_pclk"; > }; > > + watchdog0: watchdog@e0bb0000 { > + compatible = "arm,sbsa-gwdt"; > + reg = <0x0 0xe0bc0000 0 0x1000>, > + <0x0 0xe0bb0000 0 0x1000>; > + interrupts = <0 337 4>; > + timeout-sec = <15>; > + status = "disabled"; Could you please remove this status line? I do not think it is necessary for this one here anymore. Thanks, Suravee > + }; > + > spi0: ssp@e1020000 { > status = "disabled"; > compatible = "arm,pl022", "arm,primecell"; > -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html