From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH v2 2/5] mm/slub: query dynamic DEBUG_PAGEALLOC setting Date: Thu, 11 Feb 2016 13:17:42 +0100 Message-ID: <56BC7BE6.7000802@de.ibm.com> References: <1455163501-9341-1-git-send-email-iamjoonsoo.kim@lge.com> <1455163501-9341-3-git-send-email-iamjoonsoo.kim@lge.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1455163501-9341-3-git-send-email-iamjoonsoo.kim@lge.com> Sender: owner-linux-mm@kvack.org To: js1304@gmail.com, Andrew Morton Cc: David Rientjes , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Benjamin Herrenschmidt , Takashi Iwai , Chris Metcalf , Christoph Lameter , linux-api@vger.kernel.org, Joonsoo Kim List-Id: linux-api@vger.kernel.org On 02/11/2016 05:04 AM, js1304@gmail.com wrote: > From: Joonsoo Kim > > We can disable debug_pagealloc processing even if the code is compiled > with CONFIG_DEBUG_PAGEALLOC. This patch changes the code to query > whether it is enabled or not in runtime. > > v2: clean up code, per Christian. > > Signed-off-by: Joonsoo Kim Reviewed-by: Christian Borntraeger > --- > mm/slub.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 606488b..a1874c2 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -250,11 +250,10 @@ static inline void *get_freepointer_safe(struct kmem_cache *s, void *object) > { > void *p; > > -#ifdef CONFIG_DEBUG_PAGEALLOC > + if (!debug_pagealloc_enabled()) > + return get_freepointer(s, object); > + > probe_kernel_read(&p, (void **)(object + s->offset), sizeof(p)); > -#else > - p = get_freepointer(s, object); > -#endif > return p; > } > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752803AbcBKMRx (ORCPT ); Thu, 11 Feb 2016 07:17:53 -0500 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:33651 "EHLO e06smtp13.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752740AbcBKMRt (ORCPT ); Thu, 11 Feb 2016 07:17:49 -0500 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: borntraeger@de.ibm.com X-IBM-RcptTo: linux-api@vger.kernel.org;linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/5] mm/slub: query dynamic DEBUG_PAGEALLOC setting To: js1304@gmail.com, Andrew Morton References: <1455163501-9341-1-git-send-email-iamjoonsoo.kim@lge.com> <1455163501-9341-3-git-send-email-iamjoonsoo.kim@lge.com> Cc: David Rientjes , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Benjamin Herrenschmidt , Takashi Iwai , Chris Metcalf , Christoph Lameter , linux-api@vger.kernel.org, Joonsoo Kim From: Christian Borntraeger Message-ID: <56BC7BE6.7000802@de.ibm.com> Date: Thu, 11 Feb 2016 13:17:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1455163501-9341-3-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16021112-0013-0000-0000-000008971C38 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2016 05:04 AM, js1304@gmail.com wrote: > From: Joonsoo Kim > > We can disable debug_pagealloc processing even if the code is compiled > with CONFIG_DEBUG_PAGEALLOC. This patch changes the code to query > whether it is enabled or not in runtime. > > v2: clean up code, per Christian. > > Signed-off-by: Joonsoo Kim Reviewed-by: Christian Borntraeger > --- > mm/slub.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 606488b..a1874c2 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -250,11 +250,10 @@ static inline void *get_freepointer_safe(struct kmem_cache *s, void *object) > { > void *p; > > -#ifdef CONFIG_DEBUG_PAGEALLOC > + if (!debug_pagealloc_enabled()) > + return get_freepointer(s, object); > + > probe_kernel_read(&p, (void **)(object + s->offset), sizeof(p)); > -#else > - p = get_freepointer(s, object); > -#endif > return p; > } >