From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH v2 0/3] new ib_drain_qp() API Date: Thu, 11 Feb 2016 18:11:47 +0200 Message-ID: <56BCB2C3.9060408@dev.mellanox.co.il> References: <010901d16375$1a023210$4e069630$@opengridcomputing.com> <011601d1637b$8c01a3e0$a404eba0$@opengridcomputing.com> <56BA540B.4040405@sandisk.com> <011901d1637d$b5286400$1f792c00$@opengridcomputing.com> <012801d16384$f68884f0$e3998ed0$@opengridcomputing.com> <56BB11F0.9090203@dev.mellanox.co.il> <56BB4479.8090009@sandisk.com> <56BC6686.8030301@dev.mellanox.co.il> <56BCA57A.4000500@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56BCA57A.4000500-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche , Steve Wise , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" Cc: 'Sagi Grimberg' , 'Christoph Hellwig' , 'Chuck Lever' List-Id: linux-rdma@vger.kernel.org > Hello Sagi, > > The srp_send_done() function accesses the ch->free_tx list without > locking. This is safe because all existing > ib_process_cq_direct(ch->send_cq, ...) calls occur while holding > ch->lock. The approach suggested above breaks that assumption. But srp_send_done won't get invoked for the ib_drain_qp post send because ->done doesn't point to it, Am I missing something? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html