From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751912AbcBKRob (ORCPT ); Thu, 11 Feb 2016 12:44:31 -0500 Received: from mail-lb0-f181.google.com ([209.85.217.181]:35312 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635AbcBKRo3 (ORCPT ); Thu, 11 Feb 2016 12:44:29 -0500 Subject: Re: [PATCH v3 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine To: Joshua Henderson , linux-kernel@vger.kernel.org References: <1455206297-6002-2-git-send-email-joshua.henderson@microchip.com> Cc: Cristian Birsan , Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <56BCC87A.9040102@cogentembedded.com> Date: Thu, 11 Feb 2016 20:44:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1455206297-6002-2-git-send-email-joshua.henderson@microchip.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2016 06:58 PM, Joshua Henderson wrote: > From: Cristian Birsan > > Commit 754fe4a92c07 ("usb: musb: Remove ifdefs for TX DMA for musb_host.c") > introduces a problem setting the desired channel mode for the Mentor DMA > engine. > > There is a case where an address is incorrectly assigned to the DMA > channel desired mode when it should instead be assigned the actual mode > value. This results in the value of channel->desired_mode not being > correct. > > Signed-off-by: Cristian Birsan > Signed-off-by: Joshua Henderson Acked-by: Sergei Shtylyov MBR, Sergei