From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Hannes Reinecke <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
Bart van Assche <bart.vanassche@sandisk.com>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, Ewan Milne <emilne@redhat.com>
Subject: Re: [PATCH 00/23] ALUA device handler update, part II
Date: Thu, 11 Feb 2016 13:24:57 -0800 [thread overview]
Message-ID: <56BCFC29.7020508@sandisk.com> (raw)
In-Reply-To: <1454942086-128704-1-git-send-email-hare@suse.de>
On 02/08/2016 06:34 AM, Hannes Reinecke wrote:
> as promised here is now the second part of my ALUA device handler update.
Hello Hannes,
Please test this patch series with lockdep enabled and fix the
resulting complaints. This is what was reported on my test setup
shortly after multipathd was started:
=====================================
[ BUG: bad unlock balance detected! ]
4.5.0-rc3+ #6 Tainted: G E
-------------------------------------
kworker/3:1/141 is trying to release lock (port_group_lock) at:
[<ffffffffa041be19>] alua_rtpg+0x329/0x890 [scsi_dh_alua]
but there are no more locks to release!
other info that might help us debug this:
2 locks held by kworker/3:1/141:
#0: ("kaluad"){.+.+.+}, at: [<ffffffff8107225a>] process_one_work+0x16a/0x480
#1: ((&(&pg->rtpg_work)->work)){+.+.+.}, at: [<ffffffff8107225a>] process_one_work+0x16a/0x480
stack backtrace:
CPU: 3 PID: 141 Comm: kworker/3:1 Tainted: G E 4.5.0-rc3+ #6
Hardware name: Dell Inc. PowerEdge R430/03XKDV, BIOS 1.0.2 11/17/2014
Workqueue: kaluad alua_rtpg_work [scsi_dh_alua]
0000000000000000 ffff880456807978 ffffffff81263ba7 0000000000000007
0000000000000006 ffff880456ff9f80 ffffffffa041be19 ffff8804568079a8
ffffffff810a29a9 ffff8803f61b7bb8 ffff880456ff9f80 ffffffffa041d878
Call Trace:
[<ffffffff81263ba7>] dump_stack+0x6b/0xa4
[<ffffffffa041be19>] ? alua_rtpg+0x329/0x890 [scsi_dh_alua]
[<ffffffff810a29a9>] print_unlock_imbalance_bug+0xf9/0x100
[<ffffffffa041be19>] ? alua_rtpg+0x329/0x890 [scsi_dh_alua]
[<ffffffff810a68af>] __lock_release+0x25f/0x3a0
[<ffffffff810a6714>] ? __lock_release+0xc4/0x3a0
[<ffffffffa041be19>] ? alua_rtpg+0x329/0x890 [scsi_dh_alua]
[<ffffffff810a6a29>] lock_release+0x39/0x60
[<ffffffff81534799>] _raw_spin_unlock_irqrestore+0x29/0x60
[<ffffffffa041be19>] alua_rtpg+0x329/0x890 [scsi_dh_alua]
[<ffffffffa041bec5>] ? alua_rtpg+0x3d5/0x890 [scsi_dh_alua]
[<ffffffff810a6714>] ? __lock_release+0xc4/0x3a0
[<ffffffff810a3be0>] ? check_usage_forwards+0x100/0x100
[<ffffffff810a4e81>] ? mark_held_locks+0x71/0x90
[<ffffffff815347ab>] ? _raw_spin_unlock_irqrestore+0x3b/0x60
[<ffffffff810a514c>] ? trace_hardirqs_on_caller+0xfc/0x1c0
[<ffffffffa041c53e>] alua_rtpg_work+0x1be/0x370 [scsi_dh_alua]
[<ffffffff810722ca>] process_one_work+0x1da/0x480
[<ffffffff8107225a>] ? process_one_work+0x16a/0x480
[<ffffffff810a6714>] ? __lock_release+0xc4/0x3a0
[<ffffffff81073069>] worker_thread+0x169/0x520
[<ffffffff8109a1a8>] ? complete+0x48/0x60
[<ffffffff815347ab>] ? _raw_spin_unlock_irqrestore+0x3b/0x60
[<ffffffff81072f00>] ? maybe_create_worker+0x110/0x110
[<ffffffff81072f00>] ? maybe_create_worker+0x110/0x110
[<ffffffff8152f412>] ? schedule+0x42/0xb0
[<ffffffff81072f00>] ? maybe_create_worker+0x110/0x110
[<ffffffff810793e4>] kthread+0xe4/0x100
[<ffffffff810a521d>] ? trace_hardirqs_on+0xd/0x10
[<ffffffff810820e9>] ? schedule_tail+0x19/0xd0
[<ffffffff81079300>] ? __init_kthread_worker+0x70/0x70
[<ffffffff81534eff>] ret_from_fork+0x3f/0x70
[<ffffffff81079300>] ? __init_kthread_worker+0x70/0x70
sd 13:0:0:1: alua: port group 101 state A preferred supports tOlUSNA
BUG: workqueue leaked lock or atomic: kworker/3:1/0x7ffffffe/141
last function: alua_rtpg_work [scsi_dh_alua]
INFO: lockdep is turned off.
CPU: 3 PID: 141 Comm: kworker/3:1 Tainted: G E 4.5.0-rc3+ #6
Hardware name: Dell Inc. PowerEdge R430/03XKDV, BIOS 1.0.2 11/17/2014
Workqueue: kaluad alua_rtpg_work [scsi_dh_alua]
0000000000000000 ffff880456807c38 ffffffff81263ba7 0000000000000001
0000000000000000 ffff880457355960 ffff880456ff9f80 ffff880456807d28
ffffffff81072472 ffffffff8107225a ffffffff810a6714 ffffe8fffec71f05
Call Trace:
[<ffffffff81263ba7>] dump_stack+0x6b/0xa4
[<ffffffff81072472>] process_one_work+0x382/0x480
[<ffffffff8107225a>] ? process_one_work+0x16a/0x480
[<ffffffff810a6714>] ? __lock_release+0xc4/0x3a0
[<ffffffff81073069>] worker_thread+0x169/0x520
[<ffffffff8109a1a8>] ? complete+0x48/0x60
[<ffffffff815347ab>] ? _raw_spin_unlock_irqrestore+0x3b/0x60
[<ffffffff81072f00>] ? maybe_create_worker+0x110/0x110
[<ffffffff81072f00>] ? maybe_create_worker+0x110/0x110
[<ffffffff8152f412>] ? schedule+0x42/0xb0
[<ffffffff81072f00>] ? maybe_create_worker+0x110/0x110
[<ffffffff810793e4>] kthread+0xe4/0x100
[<ffffffff810a521d>] ? trace_hardirqs_on+0xd/0x10
[<ffffffff810820e9>] ? schedule_tail+0x19/0xd0
[<ffffffff81079300>] ? __init_kthread_worker+0x70/0x70
[<ffffffff81534eff>] ret_from_fork+0x3f/0x70
[<ffffffff81079300>] ? __init_kthread_worker+0x70/0x70
prev parent reply other threads:[~2016-02-11 21:25 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 14:34 [PATCH 00/23] ALUA device handler update, part II Hannes Reinecke
2016-02-08 14:34 ` [PATCH 01/23] scsi_dh_alua: Pass buffer as function argument Hannes Reinecke
2016-02-08 14:34 ` [PATCH 02/23] scsi_dh_alua: separate out alua_stpg() Hannes Reinecke
2016-02-11 23:54 ` Bart Van Assche
2016-02-08 14:34 ` [PATCH 03/23] scsi_dh_alua: Make stpg synchronous Hannes Reinecke
2016-02-08 14:34 ` [PATCH 04/23] scsi_dh_alua: call alua_rtpg() if stpg fails Hannes Reinecke
2016-02-08 14:34 ` [PATCH 05/23] scsi_dh_alua: switch to scsi_execute_req_flags() Hannes Reinecke
2016-02-08 14:34 ` [PATCH 06/23] scsi_dh_alua: allocate RTPG buffer separately Hannes Reinecke
2016-02-08 14:34 ` [PATCH 07/23] scsi_dh_alua: Use separate alua_port_group structure Hannes Reinecke
2016-02-08 14:34 ` [PATCH 08/23] scsi_dh_alua: use unique device id Hannes Reinecke
2016-02-08 14:34 ` [PATCH 09/23] scsi_dh_alua: simplify alua_initialize() Hannes Reinecke
2016-02-08 14:34 ` [PATCH 10/23] revert commit a8e5a2d593cb ("[SCSI] scsi_dh_alua: ALUA handler attach should succeed while TPG is transitioning") Hannes Reinecke
2016-02-08 14:34 ` [PATCH 11/23] scsi_dh_alua: move optimize_stpg evaluation Hannes Reinecke
2016-02-08 14:34 ` [PATCH 12/23] scsi_dh_alua: remove 'rel_port' from alua_dh_data structure Hannes Reinecke
2016-02-08 14:34 ` [PATCH 13/23] scsi_dh_alua: Use workqueue for RTPG Hannes Reinecke
2016-02-09 12:54 ` Christoph Hellwig
2016-02-08 14:34 ` [PATCH 14/23] scsi_dh_alua: Allow workqueue to run synchronously Hannes Reinecke
2016-02-08 14:34 ` [PATCH 15/23] scsi_dh_alua: Add new blacklist flag 'BLIST_SYNC_ALUA' Hannes Reinecke
2016-02-08 14:34 ` [PATCH 16/23] scsi_dh_alua: Recheck state on unit attention Hannes Reinecke
2016-02-08 14:34 ` [PATCH 17/23] scsi_dh_alua: update all port states Hannes Reinecke
2016-02-08 14:34 ` [PATCH 18/23] scsi_dh_alua: Send TEST UNIT READY to poll for transitioning Hannes Reinecke
2016-02-11 20:25 ` Ewan Milne
2016-02-12 7:12 ` Hannes Reinecke
2016-02-08 14:34 ` [PATCH 19/23] scsi_dh: add 'rescan' callback Hannes Reinecke
2016-02-11 20:27 ` Ewan Milne
2016-02-12 7:14 ` Hannes Reinecke
2016-02-08 14:34 ` [PATCH 20/23] scsi: Add 'access_state' attribute Hannes Reinecke
2016-02-11 20:33 ` Ewan Milne
2016-02-12 7:16 ` Hannes Reinecke
2016-02-08 14:34 ` [PATCH 21/23] scsi_dh_alua: use common definitions for ALUA state Hannes Reinecke
2016-02-08 14:34 ` [PATCH 22/23] scsi_dh_alua: update 'access_state' field Hannes Reinecke
2016-02-09 12:56 ` Christoph Hellwig
2016-02-11 20:37 ` Ewan Milne
2016-02-12 7:20 ` Hannes Reinecke
2016-02-08 14:34 ` [PATCH 23/23] scsi_dh_alua: Update version to 2.0 Hannes Reinecke
2016-02-08 14:37 ` [PATCH 00/23] ALUA device handler update, part II Hannes Reinecke
2016-02-08 19:39 ` Bart Van Assche
2016-02-11 1:37 ` Martin K. Petersen
2016-02-11 17:41 ` Bart Van Assche
2016-02-11 21:24 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BCFC29.7020508@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.