From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] x86: Fix build following c/s 623c720f "x86: use CLFLUSHOPT when available" Date: Thu, 11 Feb 2016 16:14:22 -0600 Message-ID: <56BD07BE.6040805@cardoe.com> References: <1455218743-12751-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5730873900169681494==" Return-path: In-Reply-To: <1455218743-12751-1-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , Xen-devel Cc: Jan Beulich List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============5730873900169681494== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lxvIStV6Ug969IkkCSvbAc88MLJ340EtJ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lxvIStV6Ug969IkkCSvbAc88MLJ340EtJ Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2/11/16 1:25 PM, Andrew Cooper wrote: > CentOS 7 gets into trouble when compiling Xen citing: >=20 > flushtlb.c: Assembler messages: > flushtlb.c:149: Error: value of 256 too large for field of 1 bytes at= 1 >=20 > The line number is wrong, and the error message not helpful. It turns = out > that the intermediate generated assembly was >=20 > # 139 "arch/x86/flushtlb.c" 1 > 661: > rex clflush (%r15) > 662: > .pushsection .altinstructions,"a" >=20 > and it was having trouble combining the explicit REX prefix with the RE= X.B > required for the use of %r15. >=20 > Follow what Linux does and use a redundant %ds prefix instead, for a fi= nal > generated instruction of `3e 41 0f ae 3f` >=20 > While modifying this line, fix the indentation which was out by one spa= ce. >=20 > Signed-off-by: Andrew Cooper Tested-by: Doug Goldstein Confirmed to fix the build issue. Results: https://travis-ci.org/cardoe/xen/builds/108653604 > --- > CC: Jan Beulich > --- > xen/arch/x86/flushtlb.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/xen/arch/x86/flushtlb.c b/xen/arch/x86/flushtlb.c > index 90a004f..727434e 100644 > --- a/xen/arch/x86/flushtlb.c > +++ b/xen/arch/x86/flushtlb.c > @@ -141,10 +141,10 @@ void flush_area_local(const void *va, unsigned in= t flags) > { > alternative(ASM_NOP3, "sfence", X86_FEATURE_CLFLUSHOPT); > for ( i =3D 0; i < sz; i +=3D c->x86_clflush_size ) > - alternative_input("rex clflush %0", > - "data16 clflush %0", > - X86_FEATURE_CLFLUSHOPT, > - "m" (((const char *)va)[i])); > + alternative_input(".byte 0x3e; clflush %0", /* %ds ove= rride. */ > + "data16 clflush %0", /* clflush= opt. */ > + X86_FEATURE_CLFLUSHOPT, > + "m" (((const char *)va)[i])); > } > else > { >=20 --=20 Doug Goldstein --lxvIStV6Ug969IkkCSvbAc88MLJ340EtJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWvQfBXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUCSkP/Rat6L2FAyAZKszsn2NZa/CO sILqREpX9QA6sMSLv6khHOgKjsNeQE/qrTTun520LJtCx/jrl7JsPoee4b8BmASJ O4KxGZsMD9sMu3+X9LvrmU7gQoKMFYSBwicgy+2p0ZestxukkMrXWpnSKGt/6Ku2 ZJg4dEhJlYlHNOMHERCHHJFOG3QaiiQYbL0yJjBzSzZGhTZg+5BJ/KvW3Hv44aU0 vuuEXNahVDYFe7d+m+667StW6XzMcWt3gnPiSeVEtMvT+Y1HsgSvkS8usDrOyPZw vEJLtAfOshXCO5jmn1lreiWWPFmZt4b4W9VQJZKHXDx0+YFLTvFxJo6WFPJ2wO9+ SQv8nDBtAURrZrrBgMMcrOOuG93xPlB08Ax3e3hcV6g+0jmb93DmpLNHa5xscaZ4 b2KsCNisPB/430mscDkNpeNhJgTcvQ8i4+KG4V3jRw3yxBMHbXKFOauWaPU1hkSJ A03B4JbkKnqhFe0PXClEipdvDGBAEjM3LWujog+Ys0bn5fHALQoP82fKwXYzm2co J73t+/dk8OFO5173c7qWpVr1LYnZGp/VSul+rcuFEgqf6wfR7Q0ZmDQpbfKKvL0X Ho3c7FC69vqfEHiSYYC+errGc6DrqU45BhgttchEYJ8CNCGiDLv3JcZLL7gVrXbT oNw6ePj6ltBhvgd3QhuF =4XTQ -----END PGP SIGNATURE----- --lxvIStV6Ug969IkkCSvbAc88MLJ340EtJ-- --===============5730873900169681494== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5730873900169681494==--