From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751255AbcBLH5g (ORCPT ); Fri, 12 Feb 2016 02:57:36 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36845 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbcBLH5e (ORCPT ); Fri, 12 Feb 2016 02:57:34 -0500 Subject: Re: [PATCH 3.12 32/64] unix: properly account for FDs passed over unix sockets To: Willy Tarreau References: <9065c7d8c8be841107dcd6711ab3779553c68fd7.1455198893.git.jslaby@suse.cz> <20160211173233.GA27734@1wt.eu> Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, "David S . Miller" , Hannes Frederic Sowa From: Jiri Slaby Message-ID: <56BD906B.9020904@suse.cz> Date: Fri, 12 Feb 2016 08:57:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160211173233.GA27734@1wt.eu> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2016, 06:32 PM, Willy Tarreau wrote: > Hi Jiri, > > On Thu, Feb 11, 2016 at 02:59:08PM +0100, Jiri Slaby wrote: >> From: willy tarreau >> >> 3.12-stable review patch. If anyone has any objections, please let me know. >> >> =============== >> >> [ Upstream commit 712f4aad406bb1ed67f3f98d04c044191f0ff593 ] >> >> It is possible for a process to allocate and accumulate far more FDs than >> the process' limit by sending them over a unix socket then closing them >> to keep the process' fd count low. >> >> This change addresses this problem by keeping track of the number of FDs >> in flight per user and preventing non-privileged processes from having >> more FDs in flight than their configured FD limit. >> >> Reported-by: socketpair@gmail.com >> Reported-by: Tetsuo Handa >> Mitigates: CVE-2013-4312 (Linux 2.0+) >> Suggested-by: Linus Torvalds >> Acked-by: Hannes Frederic Sowa >> Signed-off-by: Willy Tarreau >> Signed-off-by: David S. Miller >> Signed-off-by: Jiri Slaby > > A possible issue was reported regarding this patch, and Hannes > implemented a fix that's not yet in mainline. I guess it's > preferable to postpone this patch for now. Hi, yes definitely. Thanks for noting. For reference: http://article.gmane.org/gmane.linux.kernel/2142236 thanks, -- js suse labs