From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aU8wp-0006cU-Ti for mharc-grub-devel@gnu.org; Fri, 12 Feb 2016 03:19:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aU8wn-0006cN-UR for grub-devel@gnu.org; Fri, 12 Feb 2016 03:19:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aU8wj-0008Ag-Tc for grub-devel@gnu.org; Fri, 12 Feb 2016 03:19:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aU8wj-0008Ac-OC for grub-devel@gnu.org; Fri, 12 Feb 2016 03:19:21 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 20696804E4; Fri, 12 Feb 2016 08:19:21 +0000 (UTC) Received: from [10.36.4.100] (vpn1-4-100.ams2.redhat.com [10.36.4.100]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1C8JJQr002555 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 12 Feb 2016 03:19:20 -0500 Subject: Re: [PATCH] menu_entry: Disable cursor during update_screen() To: grub-devel@gnu.org References: <1454077618-18986-1-git-send-email-thuth@redhat.com> <56AC6740.6090008@gmail.com> From: Thomas Huth X-Enigmail-Draft-Status: N1110 Message-ID: <56BD9586.1050802@redhat.com> Date: Fri, 12 Feb 2016 09:19:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56AC6740.6090008@gmail.com> Content-Type: text/plain; charset=utf-8 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: phcoder@gmail.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2016 08:19:27 -0000 2016-01-29 17:26, Thomas Huth wrote: >> When running grub in a VGA console of a KVM pseries guest on PowerPC, >> you can see the cursor sweeping over the whole line when entering a >> character in editor mode. This is visible because grub always refreshe= s >> the whole line when entering a character in editor mode, and drawing >> characters is quite a slow operation with the firmware used for the >> powerpc pseries guests (SLOF). >> To avoid this ugliness, the cursor should be disabled when refreshing >> the screen contents during update_screen(). >> >> Signed-off-by: Thomas Huth >> --- >> grub-core/normal/menu_entry.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/grub-core/normal/menu_entry.c b/grub-core/normal/menu_ent= ry.c >> index 62c7e16..68359eb 100644 >> --- a/grub-core/normal/menu_entry.c >> +++ b/grub-core/normal/menu_entry.c >> @@ -250,6 +250,8 @@ update_screen (struct screen *screen, struct per_t= erm_screen *term_screen, >> mode =3D ALL_LINES; >> } >> =20 >> + grub_term_setcursor (term_screen->term, 0); >> + >> if (mode !=3D NO_LINE) >> { >> /* Draw lines. This code is tricky, because this must calculate= logical >> @@ -357,6 +359,8 @@ update_screen (struct screen *screen, struct per_t= erm_screen *term_screen, >> =20 >> } >> =20 >> + grub_term_setcursor (term_screen->term, 1); >> + >> grub_term_refresh (term_screen->term); >> } Ping?