From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH] vm_event: Remove xc_mem_access_enable_emulate() and friends Date: Fri, 12 Feb 2016 11:15:38 +0200 Message-ID: <56BDA2BA.2000108@bitdefender.com> References: <1455267874-14191-1-git-send-email-rcojocaru@bitdefender.com> <56BDAF9902000078000D14B4@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56BDAF9902000078000D14B4@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: tamas@tklengyel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, keir@xen.org List-Id: xen-devel@lists.xenproject.org On 02/12/2016 11:10 AM, Jan Beulich wrote: >>>> On 12.02.16 at 10:04, wrote: >> --- a/xen/include/public/memory.h >> +++ b/xen/include/public/memory.h >> @@ -390,8 +390,6 @@ DEFINE_XEN_GUEST_HANDLE(xen_mem_paging_op_t); >> #define XENMEM_access_op 21 >> #define XENMEM_access_op_set_access 0 >> #define XENMEM_access_op_get_access 1 >> -#define XENMEM_access_op_enable_emulate 2 >> -#define XENMEM_access_op_disable_emulate 3 > > Considering that the interface isn't versioned, I think you should > just comment those out instead of entirely removing them, to > make obvious for the next one to add an operation here that > these two values may not be re-used. Right, I'll do that in V2. Thanks, Razvan