From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aUF2W-0001mh-Ie for mharc-grub-devel@gnu.org; Fri, 12 Feb 2016 09:49:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUF2T-0001gx-D7 for grub-devel@gnu.org; Fri, 12 Feb 2016 09:49:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUF2S-0005sd-C9 for grub-devel@gnu.org; Fri, 12 Feb 2016 09:49:41 -0500 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:38650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUF2S-0005sZ-52 for grub-devel@gnu.org; Fri, 12 Feb 2016 09:49:40 -0500 Received: by mail-wm0-x234.google.com with SMTP id p63so22479510wmp.1 for ; Fri, 12 Feb 2016 06:49:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type; bh=fN8bhk4wPK0AKmJ/68/tJwAdDT/rffTrRmdokjPdVgI=; b=gdHd+bEXM4cLzoUYRxC3740QU2C//lBdq3+n9m99x6/85Kp2XbNbxYmy5P7MOBv7fq ErI9/CS8asktBzZH9NWIB7O9kWXqPOQr28zjDgE4ojAluszRhVIJ4H53rJlUz4bnd/5c PsfdymqcsWwoNCLYBOvsdvLo5fdfLYkK3d/JO4BZG3qFspL1JV8BXjRUD9CXWgW4l7sX PcJc0dSWE7lKmvB7lpFjr97t9RCa+JtPWSaS6FDSXClPOE/tjh1bX9vIDKu30JKQzADN gQbF3S+FpV2WsirhbPHo9G/gzm9Ka0M6riPafFxDWj7c4NTbi31uW3ewMZMPkA4rEv+1 N8/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type; bh=fN8bhk4wPK0AKmJ/68/tJwAdDT/rffTrRmdokjPdVgI=; b=KKAGVldzX5oZFyX5Xshr8GO3WoychTi10og5Z6xiuWXMdi851pvq11Os5A52GOiJmM NPcROMq9Nk6ytmOUpwjjCTYoUoGOBiyfYeHwhZY5+D9Mh8jcaoa6oPccgIMr5VQhLaGC vX/AM/hpGBPJeU+GYAZWqr5Xi46iK9eD+2Xny8DVwFMnqZRUHr4XJd3r8zsugQncmYog jSfNwJUWvnwDe15zyruNkonR8DgOMIKaZUPFq50VkFRxQzUyudmHcbIRy80NlOoIVlGL 6JLNkApyBe4citlhAuW5Z0mqdIE0eRBLRCiYcUb4aSZ/4i/LTyQgNz2vMi2q8DG+tGSI CCnQ== X-Gm-Message-State: AG10YOTox0TCzMUspGxd7ALhqEdO7Qf3q/Y2eOC1OrGK/c3TOR+iwgHTItmvwukfERvXWA== X-Received: by 10.194.61.240 with SMTP id t16mr2133023wjr.27.1455288579470; Fri, 12 Feb 2016 06:49:39 -0800 (PST) Received: from ?IPv6:2620:0:105f:fd00:a2a8:cdff:fe64:b3b5? ([2620:0:105f:fd00:a2a8:cdff:fe64:b3b5]) by smtp.gmail.com with ESMTPSA id av3sm12371378wjc.44.2016.02.12.06.49.38 for (version=TLSv1/SSLv3 cipher=OTHER); Fri, 12 Feb 2016 06:49:38 -0800 (PST) Subject: Re: [PATCH] efidisk: prevent errors from diskfilter scan of removable drives To: The development of GNU GRUB References: <1454691380-8296-1-git-send-email-arvidjaar@gmail.com> <56BDEC31.30409@gmail.com> From: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= Message-ID: <56BDF101.80003@gmail.com> Date: Fri, 12 Feb 2016 15:49:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cIxFe0rESwpkkP1upuvvgc4uGhjcPDBaG" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::234 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2016 14:49:42 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cIxFe0rESwpkkP1upuvvgc4uGhjcPDBaG Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12.02.2016 15:38, Andrei Borzenkov wrote: > On Fri, Feb 12, 2016 at 5:29 PM, Vladimir '=CF=86-coder/phcoder' Serbin= enko > wrote: >> On 05.02.2016 17:56, Andrei Borzenkov wrote: >>> Map EFI_NO_MEDIA to GRUB_ERR_OUT_OF_RANGE that is ignored by diskfilt= er. This >>> actually matches pretty close (we obviously attempt to read outside o= f media) >>> and avoids adding more error codes. >>> >>> This affects only internally initiated scans. If read/write from remo= vable is >>> explicitly requested, we still return an error and text explanation i= s more >>> clear for user than generic error. >>> >>> Reported and tested by Andreas Loew >>> >> I feel like we should be fixing diskfilter. Consider another case: dea= d >> disk dangling on cable and returning mostly I/O errors >=20 > Could you explain what do you mean? Removable media detection remains > valid case and cannot be solved without low level driver cooperation > anyway. If you mean some ratelimiting, this probably has to go into > core, not in diskfilter, but it looks orthogonal to this patch. >=20 I mean what if we have a legitimately bad disk unrelated to any diskfilter VGs. If diskfilter is unable to read from it, it should still be able to assemble VGs and skip failed disk > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --cIxFe0rESwpkkP1upuvvgc4uGhjcPDBaG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAla98QIACgkQmBXlbbo5nOuWQwD+LVBlDmX9PzmdOPklhTz+O7y5 2W+B6GHixAqQAShY6bwA/jx07g0IQG+4foT8jxEL5EbI1AfYmYcl1jXQ7AwxKP+b =e+rV -----END PGP SIGNATURE----- --cIxFe0rESwpkkP1upuvvgc4uGhjcPDBaG--