From: "Denis V. Lunev" <den@openvz.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>,
qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] migration: move bdrv_invalidate_cache_all of of coroutine context
Date: Fri, 12 Feb 2016 19:25:08 +0300 [thread overview]
Message-ID: <56BE0764.7080401@openvz.org> (raw)
In-Reply-To: <56BDD62C.5030605@redhat.com>
On 02/12/2016 03:55 PM, Paolo Bonzini wrote:
>
> On 12/02/2016 13:50, Dr. David Alan Gilbert wrote:
>> I'll admit to not really understanding what the difference is
>> between bh and coroutine context; I'd thought if it was all
>> in the main thread stuff was safe.
> It's arguably a bug in the block layer code. It assumes that all code
> called from a coroutine wants not to block. Moving stuff to a bottom
> half tells the block layer that you want bdrv_invalidate_cache_all to block.
>
> Paolo
cool description! Really short and exhaustive!
next prev parent reply other threads:[~2016-02-12 16:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 6:39 [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context Denis V. Lunev
2016-02-12 6:39 ` [Qemu-devel] [PATCH 1/2] migration: move bdrv_invalidate_cache_all of " Denis V. Lunev
2016-02-23 12:54 ` Fam Zheng
2016-02-12 6:39 ` [Qemu-devel] [PATCH 2/2] " Denis V. Lunev
2016-02-12 12:50 ` Dr. David Alan Gilbert
2016-02-12 12:55 ` Paolo Bonzini
2016-02-12 16:25 ` Denis V. Lunev [this message]
2016-02-16 5:56 ` [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out " Denis V. Lunev
2016-02-18 5:17 ` Amit Shah
2016-02-18 8:03 ` Denis V. Lunev
2016-02-18 14:54 ` Paolo Bonzini
2016-02-22 9:32 ` Amit Shah
2016-02-22 9:01 ` Denis V. Lunev
2016-02-23 7:39 ` Amit Shah
2016-02-23 10:47 ` Amit Shah
2016-02-23 12:39 ` Denis V. Lunev
-- strict thread matches above, loose matches on Subject: below --
2016-02-09 10:16 [Qemu-devel] [PATCH 1/2] migration: move bdrv_invalidate_cache_all of " Denis V. Lunev
2016-02-09 10:16 ` [Qemu-devel] [PATCH 2/2] " Denis V. Lunev
2016-02-09 15:28 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BE0764.7080401@openvz.org \
--to=den@openvz.org \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.