From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
nfont@linux.vnet.ibm.com, brking@linux.vnet.ibm.com,
jthumshirn@suse.de, manoj@linux.vnet.ibm.com
Subject: Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines
Date: Fri, 12 Feb 2016 08:51:09 -0800 [thread overview]
Message-ID: <56BE0D7D.3050703@linux.vnet.ibm.com> (raw)
In-Reply-To: <1455295395.2396.22.camel@HansenPartnership.com>
On 02/12/2016 08:43 AM, James Bottomley wrote:
> On Wed, 2016-02-10 at 19:32 -0600, Tyrel Datwyler wrote:
>> Add defines for mad version and mad os_type, and replace the magic
>> numbers in set_adapter_info() accordingly.
>>
>> Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
>> ---
>
> Is there some reason you didn't carry the review tag over from this:
>
> http://mid.gmane.org/20160204084459.GW27969@c203.arch.suse.de
>
> ?
>
> James
The patch is slightly changed from v1. A define for AIX os type was
added as mentioned in the cover letter v2 changes, and I moved the
defines to the mad_adapter_info_data structure around the fields they apply.
-Tyrel
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-02-12 16:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 1:32 [PATCH v2 0/7] ibmvscsi code cleanup Tyrel Datwyler
2016-02-11 1:32 ` Tyrel Datwyler
2016-02-11 1:32 ` [PATCH v2 1/7] ibmvscsi: Correct values for several viosrp_crq_format enums Tyrel Datwyler
2016-02-11 1:32 ` Tyrel Datwyler
2016-02-12 14:29 ` Manoj Kumar
2016-02-11 1:32 ` [PATCH v2 2/7] ibmvscsi: Add and use enums for valid CRQ header values Tyrel Datwyler
2016-02-11 8:51 ` Johannes Thumshirn
2016-02-12 14:23 ` Manoj Kumar
2016-02-11 1:32 ` [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines Tyrel Datwyler
2016-02-12 16:43 ` James Bottomley
2016-02-12 16:51 ` Tyrel Datwyler [this message]
2016-02-12 16:53 ` James Bottomley
2016-02-12 16:57 ` Martin K. Petersen
2016-02-17 3:03 ` Martin K. Petersen
2016-02-17 8:05 ` Johannes Thumshirn
2016-02-12 22:06 ` Manoj Kumar
2016-02-11 1:32 ` [PATCH v2 4/7] ibmvscsi: Use of_root to access OF device tree root node Tyrel Datwyler
2016-02-11 1:32 ` [PATCH v2 5/7] ibmvscsi: Remove unsupported host config MAD Tyrel Datwyler
2016-02-11 8:53 ` Johannes Thumshirn
2016-02-11 1:32 ` [PATCH v2 6/7] ibmvscsi: Add endian conversions to sysfs attribute show functions Tyrel Datwyler
2016-02-11 1:32 ` [PATCH v2 7/7] ibmvscsi: use H_CLOSED instead of magic number Tyrel Datwyler
2016-02-11 8:54 ` Johannes Thumshirn
2016-02-11 8:54 ` Johannes Thumshirn
2016-02-12 16:55 ` [PATCH v2 0/7] ibmvscsi code cleanup Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BE0D7D.3050703@linux.vnet.ibm.com \
--to=tyreld@linux.vnet.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=brking@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=manoj@linux.vnet.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=nfont@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.