From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH RFC] drm/atomic: Fall back to legacy call back in *_connector_dpms() Date: Fri, 12 Feb 2016 19:08:46 +0200 Message-ID: <56BE119E.9070104@ti.com> References: <20160212153455.GA11240@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0219176608==" Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2665D6E020 for ; Fri, 12 Feb 2016 09:09:03 -0800 (PST) In-Reply-To: <20160212153455.GA11240@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Jyri Sarha Cc: rmk+kernel@arm.linux.org.uk, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0219176608== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oWwp8etnSW3sqnsxag8wwJ5VmlmPCNRIH" --oWwp8etnSW3sqnsxag8wwJ5VmlmPCNRIH Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/02/16 17:34, Daniel Vetter wrote: > On Fri, Feb 12, 2016 at 05:17:19PM +0200, Jyri Sarha wrote: >> Fall back to legacy drm_helper_connector_dpms() call back in >> drm_atomic_helper_connector_dpms() if DRIVER_ATOMIC feature is not >> present. >> >> Calling drm_atomic_helper_connector_dpms() from non atomic driver >> causes undefined behavior. This is a problem with componentized >> encoder/connector drivers that may be bound to both atomic and >> non atomic drivers. >> >> Signed-off-by: Jyri Sarha >> --- >> This is just an alternative to this: >> https://lists.freedesktop.org/archives/dri-devel/2016-January/098867.h= tml >=20 > I like the linked patch much better, since non-atomic really should die= =2E > Inflicting non-atomic on atomic helpers is bad imo, so nack from me on > this patch here. I mostly agree, but we are in a transition period from non-atomic to atomic. When all drivers have been converted to atomic, it should be easy to grep for code using DRIVER_ATOMIC (or similar), and remove all the non-atomic support code. In my opinion it should be considered case by case if the non-atomic/atomic compat code should be added to the generic functions or to all the drivers using that functionality. In this case, if it only affects tda998x (but does it?), perhaps the patch in the link is better. Tomi --oWwp8etnSW3sqnsxag8wwJ5VmlmPCNRIH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWvhGeAAoJEPo9qoy8lh71CfQQAKgA68A2AWJJGBMQ20o8UWk3 2qx05jfNd5qBvhaSzYypW8DDOrLEw0ic5h3MsSVmj7doq5jFR2pZYlQVIdsdtNyo Xi7YrG23CI5sEPdze/YQMbLsQBt1OGxtiJ6cl88KLfPLxzbmPQLb024pt4onJgQ6 yCPGmfqw+fR+bTmVqepfoPL389hdLAmBXTaG4fLXaRvu3OyWrQzFpIfW0s9yPg6b YqJxxXHC7E4RgWajHmlawmIY9JYuWhVnTRu9hqFxIyGFOv/hUg2zSGbliHEOFkeB FOQqjnAEbRevj5wHlfi0HPJFtkzRXezGeai1/mle7IYTGu24mNWlR5jd1fDnzRx/ LfgsCJQcqLkG7ThNhXEF6qW7cPYDmXzNuXXx1/N6gMghl6Xv4eiBoRZKVYmngWFo 7bQQ8/4mp1wv3aYGdH8K+HWcQEEYSxFv+9T+9NXrB3fLk4sR2cbD6JzIvjMC969g HseWrjkOI8tJb7lPKJ1457RODsKbp4DavwqVrVVKlx1BjX4aFH5nRAsli38ys0G1 la53bjujBUqobxHr8eJNC+wlEnaq+WCD5v4+zRLlqZs0T4Al1cpY+T+Urfc8MZW0 oEeHxaNWn5bOanW++Adk7Q9V2eP/vMafmzjjINSnf99lUWNaRIhgMDo5mCHVq81s J2xZ33K7J2Evrfs3Th7c =wJ4o -----END PGP SIGNATURE----- --oWwp8etnSW3sqnsxag8wwJ5VmlmPCNRIH-- --===============0219176608== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0219176608==--