From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joao Pinto Subject: Re: [PATCH v7 3/3] add support for DWC UFS Host Controller Date: Fri, 12 Feb 2016 17:52:08 +0000 Message-ID: <56BE1BC8.5020604@synopsys.com> References: <20160212163636.GA31045@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160212163636.GA31045@rob-hp-laptop> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring , Joao Pinto Cc: vinholikatti@gmail.com, julian.calaby@gmail.com, akinobu.mita@gmail.com, hch@infradead.org, arnd@arndb.de, mark.rutland@arm.com, gbroner@codeaurora.org, subhashj@codeaurora.org, CARLOS.PALMINHA@synopsys.com, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org List-Id: linux-scsi@vger.kernel.org Hi Rob, On 2/12/2016 4:36 PM, Rob Herring wrote: > On Thu, Feb 11, 2016 at 12:13:06PM +0000, Joao Pinto wrote: >> +Required properties: >> +- compatible : compatible string ("snps,ufshcd-1.0", "snps,ufshcd-1.1" >> + or "snps,ufshcd-2.0") > > History has taught us this needs to have a vendor specific compatible > string as well. Don't necessarily have to define it now, but just state > a vendor string is needed too. The compatibility string already as the "snps" which is the acronym for Synopsys which is the HW Controller vendor. Isn't this enough? > >> +- reg : >> +- interrupts : >> + >> +Example: >> + ufs@0xd0000000 { >> + compatible = "snps,ufshcd-2.0"; >> + reg = < 0xd0000000 0x10000 >; >> + interrupts = < 24 >; >> + }; Thanks, Joao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752298AbcBLRxH (ORCPT ); Fri, 12 Feb 2016 12:53:07 -0500 Received: from smtprelay2.synopsys.com ([198.182.60.111]:50164 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbcBLRxF (ORCPT ); Fri, 12 Feb 2016 12:53:05 -0500 Subject: Re: [PATCH v7 3/3] add support for DWC UFS Host Controller To: Rob Herring , Joao Pinto References: <20160212163636.GA31045@rob-hp-laptop> CC: , , , , , , , , , , , , From: Joao Pinto Message-ID: <56BE1BC8.5020604@synopsys.com> Date: Fri, 12 Feb 2016 17:52:08 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160212163636.GA31045@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.13.184.19] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 2/12/2016 4:36 PM, Rob Herring wrote: > On Thu, Feb 11, 2016 at 12:13:06PM +0000, Joao Pinto wrote: >> +Required properties: >> +- compatible : compatible string ("snps,ufshcd-1.0", "snps,ufshcd-1.1" >> + or "snps,ufshcd-2.0") > > History has taught us this needs to have a vendor specific compatible > string as well. Don't necessarily have to define it now, but just state > a vendor string is needed too. The compatibility string already as the "snps" which is the acronym for Synopsys which is the HW Controller vendor. Isn't this enough? > >> +- reg : >> +- interrupts : >> + >> +Example: >> + ufs@0xd0000000 { >> + compatible = "snps,ufshcd-2.0"; >> + reg = < 0xd0000000 0x10000 >; >> + interrupts = < 24 >; >> + }; Thanks, Joao