From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f169.google.com (mail-pf0-f169.google.com [209.85.192.169]) by kanga.kvack.org (Postfix) with ESMTP id 31FAE6B0009 for ; Fri, 12 Feb 2016 13:49:20 -0500 (EST) Received: by mail-pf0-f169.google.com with SMTP id c10so52326398pfc.2 for ; Fri, 12 Feb 2016 10:49:20 -0800 (PST) Received: from mga11.intel.com (mga11.intel.com. [192.55.52.93]) by mx.google.com with ESMTP id m80si21454195pfi.252.2016.02.12.10.49.19 for ; Fri, 12 Feb 2016 10:49:19 -0800 (PST) Subject: Re: [PATCHv2 18/28] thp: prepare change_huge_pmd() for file thp References: <1455200516-132137-1-git-send-email-kirill.shutemov@linux.intel.com> <1455200516-132137-19-git-send-email-kirill.shutemov@linux.intel.com> From: Dave Hansen Message-ID: <56BE291B.3080808@intel.com> Date: Fri, 12 Feb 2016 10:48:59 -0800 MIME-Version: 1.0 In-Reply-To: <1455200516-132137-19-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" , Hugh Dickins , Andrea Arcangeli , Andrew Morton Cc: Vlastimil Babka , Christoph Lameter , Naoya Horiguchi , Jerome Marchand , Yang Shi , Sasha Levin , linux-kernel@vger.kernel.org, linux-mm@kvack.org On 02/11/2016 06:21 AM, Kirill A. Shutemov wrote: > change_huge_pmd() has assert which is not relvant for file page. > For shared mapping it's perfectly fine to have page table entry > writable, without explicit mkwrite. Should we have the bug only trigger on anonymous VMAs instead of removing it? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752730AbcBLStV (ORCPT ); Fri, 12 Feb 2016 13:49:21 -0500 Received: from mga11.intel.com ([192.55.52.93]:20832 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752671AbcBLStT (ORCPT ); Fri, 12 Feb 2016 13:49:19 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,436,1449561600"; d="scan'208";a="910920629" Subject: Re: [PATCHv2 18/28] thp: prepare change_huge_pmd() for file thp To: "Kirill A. Shutemov" , Hugh Dickins , Andrea Arcangeli , Andrew Morton References: <1455200516-132137-1-git-send-email-kirill.shutemov@linux.intel.com> <1455200516-132137-19-git-send-email-kirill.shutemov@linux.intel.com> Cc: Vlastimil Babka , Christoph Lameter , Naoya Horiguchi , Jerome Marchand , Yang Shi , Sasha Levin , linux-kernel@vger.kernel.org, linux-mm@kvack.org From: Dave Hansen Message-ID: <56BE291B.3080808@intel.com> Date: Fri, 12 Feb 2016 10:48:59 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1455200516-132137-19-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/11/2016 06:21 AM, Kirill A. Shutemov wrote: > change_huge_pmd() has assert which is not relvant for file page. > For shared mapping it's perfectly fine to have page table entry > writable, without explicit mkwrite. Should we have the bug only trigger on anonymous VMAs instead of removing it?