From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: eth: fix memalign() parameter order
Date: Fri, 12 Feb 2016 21:57:24 +0100 [thread overview]
Message-ID: <56BE4734.7080507@denx.de> (raw)
In-Reply-To: <1455310561-4987-1-git-send-email-swarren@wwwdotorg.org>
On 02/12/2016 09:56 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> The alignment and size were swapped, leading to malloc heap corruption.
>
> On my system, this sometimes caused U-Boot to crash during or after
> certain USB Ethernet operations.
>
> Fixes: c8c2797c3810 ("dm: usb: eth: Support driver model with USB Ethernet")
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
Oh this is a nice catch!
Acked-by: Marek Vasut <marex@denx.de>
> ---
> drivers/usb/eth/usb_ether.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/eth/usb_ether.c b/drivers/usb/eth/usb_ether.c
> index b9c9a8402e39..36734e2e51b3 100644
> --- a/drivers/usb/eth/usb_ether.c
> +++ b/drivers/usb/eth/usb_ether.c
> @@ -73,7 +73,7 @@ int usb_ether_register(struct udevice *dev, struct ueth_data *ueth, int rxsize)
> }
>
> ueth->rxsize = rxsize;
> - ueth->rxbuf = memalign(rxsize, ARCH_DMA_MINALIGN);
> + ueth->rxbuf = memalign(ARCH_DMA_MINALIGN, rxsize);
> if (!ueth->rxbuf)
> return -ENOMEM;
>
>
next prev parent reply other threads:[~2016-02-12 20:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 20:56 [U-Boot] [PATCH] usb: eth: fix memalign() parameter order Stephen Warren
2016-02-12 20:57 ` Marek Vasut [this message]
2016-02-12 21:09 ` Simon Glass
2016-02-12 21:15 ` Joe Hershberger
2016-02-12 21:16 ` Marek Vasut
2016-02-22 16:56 ` Stephen Warren
2016-02-24 18:16 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BE4734.7080507@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.