From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Subject: Re: [PATCH] net: phy: spi_ks8995: add dependency on GPIO Date: Sat, 13 Feb 2016 19:35:40 +0530 Message-ID: <56BF3834.2090708@gmail.com> References: <1455272306-30251-1-git-send-email-sudipm.mukherjee@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=ueJEsgstCXyewvfXfY6FBIFKRvsUWxWKmiZynHBJfI8=; b=LxHf8/muKd6qgRITJc7SybeFnvbKF+1bsTTPyFQ1dw71VOTS2ztZrxBb0Xuro4kMG2 UURNQt68zliXSECpxtWC5fwv1QRTeRTKfqxa+Lui/k2Qa9ETgQODh14Mp27xBMyJf2uM N0IwNMpJK3/SQXrqckWne+0tXybK6MpO6JjAgZ3/U690TmGT0MZRsGHucV6u1S4uw+Rp oLY2Z07vHI5z65os7RUCppLAHDn2jashwJ0Ex/e76JrY8l4GFfDwkQl+HNhUm+qTZDt/ 9B+v4RT+cnysZeUb3/BL38QZ2rSRL5VWs6uL9VF5B+e5o8pBoyR0YeISlHZhuoLq+6NB 6/+A== In-Reply-To: Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Geert Uytterhoeven Cc: Florian Fainelli , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "David S. Miller" , Helmut Buchsbaum On Saturday 13 February 2016 03:42 PM, Geert Uytterhoeven wrote: > On Fri, Feb 12, 2016 at 11:18 AM, Sudip Mukherjee > wrote: >> The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing >> with the error: >> drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' >> drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc' > > Does that file include include/linux/gpio/consumer.h? > The GPIO subsystem provides dummies of these functions when CONFIG_GPIOLIB=n. > >> GPIO is now used to reset the switch so we should have a dependency on >> GPIOLIB. >> >> Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO") >> Cc: Helmut Buchsbaum >> Signed-off-by: Sudip Mukherjee >> --- >> drivers/net/phy/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig >> index f0a7702..c6a4fe1 100644 >> --- a/drivers/net/phy/Kconfig >> +++ b/drivers/net/phy/Kconfig >> @@ -261,4 +261,4 @@ endif # PHYLIB >> >> config MICREL_KS8995MA >> tristate "Micrel KS8995MA 5-ports 10/100 managed Ethernet switch" >> - depends on SPI >> + depends on SPI && GPIOLIB > > I think that can become > > depends on SPI > depends on GPIOLIB || COMPILE_TEST > > after you've added the missing include. yes, ofcourse. Better change that what I have done. Just sent v2 after compile testing this change. regards sudip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751491AbcBMOFz (ORCPT ); Sat, 13 Feb 2016 09:05:55 -0500 Received: from mail-pf0-f172.google.com ([209.85.192.172]:32857 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751231AbcBMOFx (ORCPT ); Sat, 13 Feb 2016 09:05:53 -0500 Message-ID: <56BF3834.2090708@gmail.com> Date: Sat, 13 Feb 2016 19:35:40 +0530 From: Sudip Mukherjee User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Geert Uytterhoeven CC: Florian Fainelli , "linux-kernel@vger.kernel.org" , kernel-testers@vger.kernel.org, "netdev@vger.kernel.org" , "David S. Miller" , Helmut Buchsbaum Subject: Re: [PATCH] net: phy: spi_ks8995: add dependency on GPIO References: <1455272306-30251-1-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 13 February 2016 03:42 PM, Geert Uytterhoeven wrote: > On Fri, Feb 12, 2016 at 11:18 AM, Sudip Mukherjee > wrote: >> The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing >> with the error: >> drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' >> drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc' > > Does that file include include/linux/gpio/consumer.h? > The GPIO subsystem provides dummies of these functions when CONFIG_GPIOLIB=n. > >> GPIO is now used to reset the switch so we should have a dependency on >> GPIOLIB. >> >> Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO") >> Cc: Helmut Buchsbaum >> Signed-off-by: Sudip Mukherjee >> --- >> drivers/net/phy/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig >> index f0a7702..c6a4fe1 100644 >> --- a/drivers/net/phy/Kconfig >> +++ b/drivers/net/phy/Kconfig >> @@ -261,4 +261,4 @@ endif # PHYLIB >> >> config MICREL_KS8995MA >> tristate "Micrel KS8995MA 5-ports 10/100 managed Ethernet switch" >> - depends on SPI >> + depends on SPI && GPIOLIB > > I think that can become > > depends on SPI > depends on GPIOLIB || COMPILE_TEST > > after you've added the missing include. yes, ofcourse. Better change that what I have done. Just sent v2 after compile testing this change. regards sudip