From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] spi: s3c64xx: Get fifosize via device tree Date: Sun, 14 Feb 2016 16:01:08 +0900 Message-ID: <56C02634.8020204@samsung.com> References: <1455031585-11113-1-git-send-email-ym0914@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1455031585-11113-1-git-send-email-ym0914-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Youngmin Nam , kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: k.kozlowski.k-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-samsung-soc@vger.kernel.org W dniu 10.02.2016 o 00:26, Youngmin Nam pisze: > SPI driver on some SoCs only differ in the fifosize of each > SPI channel. It is useless to duplicate the s3c64xx_spi_port_config structure > or create a compatible name for such a change. > > We can get fifosize via the device tree nodes (not mandatory). > Also the device tree binding document was updated. > > Signed-off-by: Youngmin Nam > --- > Documentation/devicetree/bindings/spi/spi-samsung.txt | 6 ++++++ > drivers/spi/spi-s3c64xx.c | 13 +++++++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-samsung.txt b/Documentation/devicetree/bindings/spi/spi-samsung.txt > index 6dbdeb3..5c4a08d 100644 > --- a/Documentation/devicetree/bindings/spi/spi-samsung.txt > +++ b/Documentation/devicetree/bindings/spi/spi-samsung.txt > @@ -23,6 +23,11 @@ Required SoC Specific Properties: > - dma-names: Names for the dma channels. There must be at least one channel > named "tx" for transmit and named "rx" for receive. > > +Optional SoC Specific properties: > + > +- samsung,spi-fifosize: The fifo size supported by the SPI channel > + > + > Required Board Specific Properties: > > - #address-cells: should be 1. > @@ -73,6 +78,7 @@ Example: > dma-names = "tx", "rx"; > #address-cells = <1>; > #size-cells = <0>; > + samsung,spi-fifosize = <64>; > }; > That does not look good. Is it a configurable part of SoC? I think not... rather it must contain exact value supported by given device... So this should be part of compatible because AFAIU you just made compatible devices uncompatible... Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html