From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aUqrK-0003Q7-QT for mharc-grub-devel@gnu.org; Sun, 14 Feb 2016 02:12:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUqrI-0003Pt-JY for grub-devel@gnu.org; Sun, 14 Feb 2016 02:12:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUqrF-0005I9-Dt for grub-devel@gnu.org; Sun, 14 Feb 2016 02:12:40 -0500 Received: from mail-lf0-x22d.google.com ([2a00:1450:4010:c07::22d]:33954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUqrF-0005I4-5n for grub-devel@gnu.org; Sun, 14 Feb 2016 02:12:37 -0500 Received: by mail-lf0-x22d.google.com with SMTP id j78so72831902lfb.1 for ; Sat, 13 Feb 2016 23:12:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=yXd4nfvSrf5cNelsHnLb83PJeQaJIv0AVySVjuW0h+g=; b=QAjdU8W2bDf/AgV/pwES+pJc4OB9R2gUydJCxtAzMlQcbhT3LcD2M20ms49JcHHVT/ dMs0CuNXfTH/hiD6IbxminKo7g5uManF+oquV9Tuuv4H2joJu6rYzziRYWpX4CEGxcg7 wHMNyx/Ub7jKBr3F14PWkNvih366fH1K9HO99ywOn/UHtaIjjQGU1EQVAJy4Fge97Bq9 lEbHuFA8NtVDVHTdaDTNVe3l99bRzapZr4GEczEKlBziyb5js6xeb/t2tf8T3e+oYvWD bA8v3hxz6+nr15P1fb8kEVhd56Q+91iVtBl+muM2xeG2O9Y5lehhpaU+02Yy6VJteB4X dBZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=yXd4nfvSrf5cNelsHnLb83PJeQaJIv0AVySVjuW0h+g=; b=kmh1Y8KY61rWTLhKPtOLFJf/ARPOM6jlAt3sLqQgcqfifjPg1KymzHNx5iUW9QsRZU nb1trsrTGjDbyROuRBY3H6FkkoISm3ukaojvzZzfb/N4LCFYhj8Rcc9n7ZurVzqgCfqw hHj04qdlJHbK+lJTFt4NqIMx0fyuzHlGXaBqiTiLyKDR8eiyObFwnjxaseGNT6eDuhuZ aopb4CIUJrmQkpOvtbtIfYrEz5z/RDeQGOL+16GKIhDy4Wpm/v/P8qyOcSCNSpl74TyD mmgC7Vhh09U3ieqn3nM1kFVv07+yt7WJ+zg/sBl0cbPNmlMZOpeXjXFqqlT/GyCuckv8 hKzA== X-Gm-Message-State: AG10YOQ3bCOsxJwdHKWrY/UdFLxP7zKIvMYsQw1G/Z8Mq0whKlx0NbAD734V1vUrx7RHOQ== X-Received: by 10.25.142.201 with SMTP id q192mr3453013lfd.65.1455433956340; Sat, 13 Feb 2016 23:12:36 -0800 (PST) Received: from [192.168.1.41] (ppp109-252-76-159.pppoe.spdop.ru. [109.252.76.159]) by smtp.gmail.com with ESMTPSA id e66sm2913477lfg.23.2016.02.13.23.12.34 for (version=TLSv1/SSLv3 cipher=OTHER); Sat, 13 Feb 2016 23:12:35 -0800 (PST) Subject: Re: multiboot_mmap_entry.zero isn't zero To: The development of GNU GRUB References: From: Andrei Borzenkov Message-ID: <56C028E2.5000502@gmail.com> Date: Sun, 14 Feb 2016 10:12:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::22d X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Feb 2016 07:12:41 -0000 14.02.2016 00:20, Wink Saville пишет: > I'm processing multiboot_tag_mmap and the multiboot_mmap_entry.zero > isn't zero. As best as I can tell grub isn't initializing it. Here is > the code from grub-core/loader/i386/multiboot_mbi.c: > > /* Helper for grub_fill_multiboot_mmap. */ > static int > grub_fill_multiboot_mmap_iter (grub_uint64_t addr, grub_uint64_t size, > grub_memory_type_t type, void *data) > { > struct multiboot_mmap_entry **mmap_entry = data; > > (*mmap_entry)->addr = addr; > (*mmap_entry)->len = size; > (*mmap_entry)->type = type; > (*mmap_entry)->size = sizeof (struct multiboot_mmap_entry) - sizeof > ((*mmap_entry)->size); > (*mmap_entry)++; > > return 0; > } > > And similar code in grub-core/loader/multiboot_mbi2.c: > > /* Helper for grub_fill_multiboot_mmap. */ > static int > grub_fill_multiboot_mmap_iter (grub_uint64_t addr, grub_uint64_t size, > grub_memory_type_t type, void *data) > { > struct multiboot_mmap_entry **mmap_entry = data; > > (*mmap_entry)->addr = addr; > (*mmap_entry)->len = size; > (*mmap_entry)->type = type; > (*mmap_entry)++; > > return 0; > } > > And I'd expect to see: > > (*mmap_entry)->zero = 0; > > Is there a reason its not being zeroed? > Because it does not exist?