From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUt0V-00079d-Ie for qemu-devel@nongnu.org; Sun, 14 Feb 2016 04:30:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUt0Q-000656-IO for qemu-devel@nongnu.org; Sun, 14 Feb 2016 04:30:19 -0500 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:33733) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUt0Q-00064y-BR for qemu-devel@nongnu.org; Sun, 14 Feb 2016 04:30:14 -0500 Received: by mail-wm0-x243.google.com with SMTP id c200so10658560wme.0 for ; Sun, 14 Feb 2016 01:30:14 -0800 (PST) References: <1455020010-17532-1-git-send-email-clg@fr.ibm.com> <1455020010-17532-8-git-send-email-clg@fr.ibm.com> From: Marcel Apfelbaum Message-ID: <56C04923.2020108@gmail.com> Date: Sun, 14 Feb 2016 11:30:11 +0200 MIME-Version: 1.0 In-Reply-To: <1455020010-17532-8-git-send-email-clg@fr.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 7/8] ipmi: introduce an ipmi_bmc_sdr_find() API Reply-To: marcel@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Corey Minyard Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Greg Kurz On 02/09/2016 02:13 PM, Cédric Le Goater wrote: > This patch exposes a new IPMI routine to query a sdr entry from the > sdr table maintained by the IPMI BMC simulator. The API is very > similar to the internal sdr_find_entry() routine and should be used > the same way to query one or all sdrs. > > A typical use would be to loop on the sdrs to build nodes of a device > tree. > > Signed-off-by: Cédric Le Goater > --- > hw/ipmi/ipmi_bmc_sim.c | 16 ++++++++++++++++ > include/hw/ipmi/ipmi.h | 2 ++ > 2 files changed, 18 insertions(+) > > diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c > index b0754893fc08..c952219429f4 100644 > --- a/hw/ipmi/ipmi_bmc_sim.c > +++ b/hw/ipmi/ipmi_bmc_sim.c > @@ -406,6 +406,22 @@ static int sdr_find_entry(IPMISdr *sdr, uint16_t recid, > return 1; > } > > +int ipmi_bmc_sdr_find(IPMIBmc *b, uint16_t recid, > + const struct ipmi_sdr_compact **sdr, uint16_t *nextrec) > + > +{ > + IPMIBmcSim *ibs = IPMI_BMC_SIMULATOR(b); > + unsigned int pos; > + > + pos = 0; > + if (sdr_find_entry(&ibs->sdr, recid, &pos, nextrec)) { > + return -1; > + } > + > + *sdr = (const struct ipmi_sdr_compact *) &ibs->sdr.sdr[pos]; > + return 0; > +} > + > static void sel_inc_reservation(IPMISel *sel) > { > sel->reservation++; > diff --git a/include/hw/ipmi/ipmi.h b/include/hw/ipmi/ipmi.h > index 74a2b5af9613..e41321db174d 100644 > --- a/include/hw/ipmi/ipmi.h > +++ b/include/hw/ipmi/ipmi.h > @@ -255,4 +255,6 @@ struct ipmi_sdr_compact { > > typedef uint8_t ipmi_sdr_compact_buffer[sizeof(struct ipmi_sdr_compact)]; > > +int ipmi_bmc_sdr_find(IPMIBmc *b, uint16_t recid, > + const struct ipmi_sdr_compact **sdr, uint16_t *nextrec); This method is not used yet. I suppose you have a work in progress using it, I suggest to add this to your next series when it will be used. Thanks, Marcel > #endif >