From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haggai Eran Subject: Re: [RFC 0/7] Peer-direct memory Date: Sun, 14 Feb 2016 16:05:31 +0200 Message-ID: <56C089AB.4060100@mellanox.com> References: <1455207177-11949-1-git-send-email-artemyko@mellanox.com> <20160211191838.GA23675@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160211191838.GA23675-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe , Kovalyov Artemy Cc: "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-mm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "leon-Dj0/KMMU01E@public.gmane.org" , Sagi Grimberg List-Id: linux-rdma@vger.kernel.org On 11/02/2016 21:18, Jason Gunthorpe wrote: > Resubmit those parts under the mm subsystem, or another more > appropriate place. We want the feedback from linux-mm, and they are Cced. > If you want to make some incremental progress then implement the > existing ZONE_DEVICE API for the IB core and add the invalidate stuff > later, once you've negotiated a common API for that with linux-mm. So there are couple of issues we currently have with ZONE_DEVICE. Perhaps they can be solved and then we could use it directly. First, I'm not sure it is intended to be used for our purpose. memremap() has this comment [1]: > memremap() is "ioremap" for cases where it is known that the resource > being mapped does not have i/o side effects and the __iomem > annotation is not applicable. Does this apply also to devm_memremap_pages()? Because the HCA BAR clearly doesn't fall under this definition. Second, there's a requirement that ZONE_DEVICE ranges are aligned to section-boundary, right? We have devices that have 8MB or 32MB BARs, so they won't work with 128MB sections on x86_64. Third, I understand there was a desire to place ZONE_DEVICE page structs in the device itself. This can work for pmem, but obviously won't work for an I/O device BAR like an HCA. Regards, Haggai [1] http://lxr.free-electrons.com/source/kernel/memremap.c?v=4.4#L38 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html