All of lore.kernel.org
 help / color / mirror / Atom feed
From: Haggai Eran <haggaie@mellanox.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Kovalyov Artemy <artemyko@mellanox.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"leon@leon.ro" <leon@leon.ro>, Sagi Grimberg <sagig@mellanox.com>
Subject: Re: [RFC 0/7] Peer-direct memory
Date: Sun, 14 Feb 2016 16:27:20 +0200	[thread overview]
Message-ID: <56C08EC8.10207@mellanox.com> (raw)
In-Reply-To: <20160211191838.GA23675@obsidianresearch.com>

[apologies: sending again because linux-mm address was wrong]

On 11/02/2016 21:18, Jason Gunthorpe wrote:
> Resubmit those parts under the mm subsystem, or another more
> appropriate place.

We want the feedback from linux-mm, and they are now Cced.

> If you want to make some incremental progress then implement the
> existing ZONE_DEVICE API for the IB core and add the invalidate stuff
> later, once you've negotiated a common API for that with linux-mm.

So there are couple of issues we currently have with ZONE_DEVICE. 
Perhaps they can be solved and then we could use it directly.

First, I'm not sure it is intended to be used for our purpose. 
memremap() has this comment [1]:
> memremap() is "ioremap" for cases where it is known that the resource
> being mapped does not have i/o side effects and the __iomem
> annotation is not applicable. 

Does this apply also to devm_memremap_pages()? Because the HCA BAR 
clearly doesn't fall under this definition.

Second, there's a requirement that ZONE_DEVICE ranges are aligned to 
section-boundary, right? We have devices that have 8MB or 32MB BARs, 
so they won't work with 128MB sections on x86_64.

Third, I understand there was a desire to place ZONE_DEVICE page structs 
in the device itself. This can work for pmem, but obviously won't work 
for an I/O device BAR like an HCA.

Regards,
Haggai

[1] http://lxr.free-electrons.com/source/kernel/memremap.c?v=4.4#L38

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2016-02-14 14:27 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-11 16:12 [RFC 0/7] Peer-direct memory Artemy Kovalyov
     [not found] ` <1455207177-11949-1-git-send-email-artemyko-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-02-11 16:12   ` [RFC 1/7] IB/core: Introduce peer client interface Artemy Kovalyov
2016-02-11 16:12   ` [RFC 2/7] IB/core: Get/put peer memory client Artemy Kovalyov
2016-02-11 16:12   ` [RFC 3/7] IB/core: Umem tunneling peer memory APIs Artemy Kovalyov
2016-02-11 16:12   ` [RFC 4/7] IB/core: Infrastructure to manage peer core context Artemy Kovalyov
2016-02-11 16:12   ` [RFC 5/7] IB/core: Invalidation support for peer memory Artemy Kovalyov
2016-02-11 16:12   ` [RFC 6/7] IB/core: Peer memory client for IO memory Artemy Kovalyov
2016-02-11 16:12   ` [RFC 7/7] IB/mlx5: Invalidation support for MR over peer memory Artemy Kovalyov
2016-02-11 19:18   ` [RFC 0/7] Peer-direct memory Jason Gunthorpe
     [not found]     ` <20160211191838.GA23675-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-12 20:13       ` Christoph Hellwig
     [not found]         ` <20160212201328.GA14122-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-02-12 20:36           ` Jason Gunthorpe
     [not found]             ` <20160212203649.GA10540-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-02-14 15:25               ` Sagi Grimberg
     [not found]                 ` <56C09C7E.4060808-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-02-18 14:44                   ` Stephen Bates
2016-02-21  9:06                     ` Haggai Eran
     [not found]                       ` <56C97E13.9090101-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-02-24 23:45                         ` Stephen Bates
2016-02-24 23:45                           ` Stephen Bates
2016-02-25 11:27                           ` Haggai Eran
2016-02-14 14:09           ` Haggai Eran
2016-02-14 14:05       ` Haggai Eran
2016-02-14 14:27     ` Haggai Eran [this message]
2016-02-16 18:22       ` Jason Gunthorpe
2016-02-17  4:03         ` davide rossetti
     [not found]           ` <CAPSaadxbFCOcKV=c3yX7eGw9Wqzn3jvPRZe2LMWYmiQcijT4nw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-17  4:13             ` davide rossetti
2016-02-17  4:13               ` davide rossetti
2016-02-17  4:44               ` Jason Gunthorpe
2016-02-17  8:49                 ` Christoph Hellwig
     [not found]                   ` <20160217084959.GB13616-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-02-18 17:12                     ` Jason Gunthorpe
2016-02-18 17:12                       ` Jason Gunthorpe
     [not found]               ` <CAPSaadx3vNBSxoWuvjrTp2n8_-DVqofttFGZRR+X8zdWwV86nw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-17  8:44                 ` Christoph Hellwig
2016-02-17  8:44                   ` Christoph Hellwig
2016-02-17 15:25                   ` Haggai Eran
     [not found]                     ` <56C490DF.1090100-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-02-19 18:54                       ` Dan Williams
2016-02-19 18:54                         ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C08EC8.10207@mellanox.com \
    --to=haggaie@mellanox.com \
    --cc=artemyko@mellanox.com \
    --cc=dledford@redhat.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=leon@leon.ro \
    --cc=linux-mm@kvack.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sagig@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.