Re: [PATCH v3 2/3] i386: Add support for loading from android bootimg

[Andrei Borzenkov <arvidjaar@gmail.com>]

14.02.2016 16:26, Vladimir 'phcoder' Serbinenko пишет:
> Le dim. 14 févr. 2016 14:21, Shea Levy <shea@shealevy.com> a écrit :
> 
>> This patch uses grub_file_open, but the android bootimg is a disk, not
>> a file. You mentioned something about file_offset_open, but that also
>> expects an input file, not a disk. Should I modify your patch with my
>> code I wrote to create a grub_file_t from an android_bootimg disk
>> device, or is there another approach?
>>
> We already have syntax (hd0,1)+<number of sectors> that we use for i.a.
> chainloader perhaps we should extend it to have (hd0,1)+ meaning whole disk
> as file? Or even allow the disk to be opened with GRUB_file_open? I'd like
> a second opinion on this. Andrei, what do you think?
> 

Yes, it was discussed just recently on help-grub. I'd prefer ($dev)+ as
explicit indication that we want blocklists.

The practical problem is that we must allow unknown file size. I am not
sure how deep changes are required. But as the trivial example, what "ls
-l ($dev)+" is going to output? Is "test -s ($dev)+" true or false when
size is unknown?