From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52441)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1aV1wG-0005d0-1a
	for qemu-devel@nongnu.org; Sun, 14 Feb 2016 14:02:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark.cave-ayland@ilande.co.uk>) id 1aV1wF-00071q-3z
	for qemu-devel@nongnu.org; Sun, 14 Feb 2016 14:02:31 -0500
References: <1454877256-22138-1-git-send-email-hpoussin@reactos.org>
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Message-ID: <56C0CF1C.4010006@ilande.co.uk>
Date: Sun, 14 Feb 2016 19:01:48 +0000
MIME-Version: 1.0
In-Reply-To: <1454877256-22138-1-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v2 00/13] cuda: misc fixes and cleanups
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Herv=c3=a9_Poussineau?= <hpoussin@reactos.org>, qemu-devel@nongnu.org
Cc: Alyssa Milburn <fuzzie@fuzzie.org>, qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>, David Gibson <david@gibson.dropbear.id.au>

On 07/02/16 20:34, Hervé Poussineau wrote:

> Hi,
> 
> This patchset cleans up a little bit the Apple CUDA emulation:
> - correctly reject commands with wrong parameters
> - support changing the frequency of auto-polling
> - support changing device list probed in auto-poll
> - add logs when using FILE_SERVER_FLAG/SET_POWER_MESSAGE
> - remove unused commands (GET/SET_6805_ADDR)
> - remove unimplemented GET_SET_IIC/COMBINED_FORMAT_IIC
> 
> GET_SET_IIC/COMBINED_FORMAT_IIC commands should be added again once
> we implement the I2C bus provided by CUDA.
> 
> Hervé
> 
> Hervé Poussineau (13):
>   cuda: add a framework to handle commands
>   cuda: move unknown commands reject out of switch
>   cuda: port AUTOPOLL command to new framework
>   cuda: port SET_AUTO_RATE command to new framework
>   cuda: port SET_DEVICE_LIST command to new framework
>   cuda: port POWERDOWN command to new framework
>   cuda: port RESET_SYSTEM command to new framework
>   cuda: port FILE_SERVER_FLAG command to new framework
>   cuda: port SET_POWER_MESSAGES command to new framework
>   cuda: port GET_TIME command to new framework
>   cuda: port SET_TIME command to new framework
>   cuda: remove GET_6805_ADDR command
>   cuda: remove CUDA_GET_SET_IIC/CUDA_COMBINED_FORMAT_IIC commands
> 
>  hw/input/adb.c         |  18 ++--
>  hw/misc/macio/cuda.c   | 279 ++++++++++++++++++++++++++++++++++++-------------
>  hw/ppc/mac.h           |   2 +
>  include/hw/input/adb.h |   2 +-
>  4 files changed, 217 insertions(+), 84 deletions(-)

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

This looks good to me, and again passes all my local tests. The only
thing I noticed was that there were no changes related to
qemu_log_mask() as per David's comments on patch 2 but other than that I
think this patchset is fine to merge for 2.6.


ATB,

Mark.