From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: Gavin Shan <gwshan@linux.vnet.ibm.com>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/eeh: Remove duplicated check in eeh_dump_pe_log()
Date: Mon, 15 Feb 2016 14:25:53 +1100 [thread overview]
Message-ID: <56C14541.5000302@au1.ibm.com> (raw)
In-Reply-To: <1455493946-27967-1-git-send-email-gwshan@linux.vnet.ibm.com>
On 15/02/16 10:52, Gavin Shan wrote:
> When eeh_dump_pe_log() is called in eeh_slot_error_detail(), we
> already have the check that the PE isn't in PCI config blocked
> state. So we needn't the duplicated check in eeh_dump_pe_log().
>
> This removes the duplicated check in eeh_dump_pe_log().
>
> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
eeh_dump_pe_log() isn't called anywhere outside of
eeh_slot_error_detail(), so this should have no functional change.
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
--
Andrew Donnellan Software Engineer, OzLabs
andrew.donnellan@au1.ibm.com Australia Development Lab, Canberra
+61 2 6201 8874 (work) IBM Australia Limited
next prev parent reply other threads:[~2016-02-15 3:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 23:52 [PATCH] powerpc/eeh: Remove duplicated check in eeh_dump_pe_log() Gavin Shan
2016-02-15 3:25 ` Andrew Donnellan [this message]
2016-02-15 23:30 ` Gavin Shan
2016-02-15 23:58 ` Andrew Donnellan
2016-02-26 0:13 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C14541.5000302@au1.ibm.com \
--to=andrew.donnellan@au1.ibm.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.