From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH v4 09/10] arm64: dts: Add main Thermal info to rk3368.dtsi Date: Mon, 15 Feb 2016 11:36:36 +0800 Message-ID: <56C147C4.20704@gmail.com> References: <1447044542-30859-1-git-send-email-wxt@rock-chips.com> <1447044542-30859-10-git-send-email-wxt@rock-chips.com> <42802946.20XC68fnyM@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <42802946.20XC68fnyM@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Heiko Stuebner Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Caesar Wang List-Id: linux-rockchip.vger.kernel.org CgrlnKggMjAxNuW5tDAy5pyIMDnml6UgMTY6MzAsIEhlaWtvIFN0dWVibmVyIOWGmemBkzoKPiBI aSBDYWVzYXIsCj4KPiBBbSBNb250YWcsIDkuIE5vdmVtYmVyIDIwMTUsIDEyOjQ5OjAxIHNjaHJp ZWIgQ2Flc2FyIFdhbmc6Cj4+IFRoaXMgcGF0Y2ggYWRkIHRoZSB0aGVybWFsIG5lZWRlZCBpbmZv IG9uIFJLMzM2OC4KPj4gTWVhbndoaWxlLCBzdXBwb3J0IHRoZSB0cmlwcyB0byB0aHJvdHRsZSBm b3IgdGhlcm1hbC4KPj4KPj4gU2lnbmVkLW9mZi1ieTogQ2Flc2FyIFdhbmcgPHd4dEByb2NrLWNo aXBzLmNvbT4KPj4gQWNrZWQtYnk6IEVkdWFyZG8gVmFsZW50aW4gPGVkdWJlenZhbEBnbWFpbC5j b20+Cj4gWy4uLl0KPgo+PiBAQCAtODI5LDYgKzg1NSwxNiBAQAo+PiAgIAkJCX07Cj4+ICAgCQl9 Owo+Pgo+PiArCQl0c2FkYyB7Cj4+ICsJCQlvdHBfZ3Bpbzogb3RwLWdwaW8gewo+PiArCQkJCXJv Y2tjaGlwLHBpbnMgPSA8MCAxMCBSS19GVU5DX0dQSU8gJnBjZmdfcHVsbF9ub25lPjsKPj4gKwkJ CX07Cj4+ICsKPj4gKwkJCW90cF9vdXQ6IG90cC1vdXQgewo+PiArCQkJCXJvY2tjaGlwLHBpbnMg PSA8MCAxMCBSS19GVU5DXzEgJnBjZmdfcHVsbF9ub25lPjsKPj4gKwkJCX07Cj4+ICsJCX07Cj4+ ICsKPj4gICAJCXVhcnQwIHsKPj4gICAJCQl1YXJ0MF94ZmVyOiB1YXJ0MC14ZmVyIHsKPj4gICAJ CQkJcm9ja2NoaXAscGlucyA9IDwyIDI0IFJLX0ZVTkNfMSAmcGNmZ19wdWxsX3VwPiwKPiBBcyBp dCBjYW1lIHVwIGp1c3Qgbm93LCB0aGVzZSBwaW5jdHJsIHNldHRpbmdzIHNlZW0gc3RyYW5nZS4g SS5lLiBhY2NvcmRpbmcKPiB0byB0aGUgVFJNIGdwaW8wYjIgWz0gZ3BpbzAgMTBdIGZ1bmNfMSBp cyBzY19yc3QsIHdoaWNoIHNlZW1zIHRvIGJlIHRoZQo+IHNtYXJ0Y2FyZCBjb250cm9sbGVyPwo+ Cj4gSXQgY2FtZSB1cCBiZWNhdXNlIGl0IHNlZW1zIHRoZSBUcm9uc21hcnQgUjY4IGJvYXJkIHNl ZW1zIHRvIHVzZSB0aGlzIHBpbgo+IGZvciBjb250cm9sbGluZyB0aGUgdmNjX2hvc3QgcmVndWxh dG9yIGluc3RlYWQuCgpZZXAsIHRoYXQncyB0aGUgaW5jb3JyZWN0IG92ZXItdGVtcGVyYXR1cmUg cHJvdGVjdGlvbiBwaW4uIDotKAoKRml4ZWQgaW4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9y Zy9wYXRjaC84MzA4ODMxLwoKVGhhbmtzIEhlaWtvLgoKPgo+IEhlaWtvCj4KPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IExpbnV4LXJvY2tjaGlwIG1h aWxpbmcgbGlzdAo+IExpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCgoKLS0g ClRoYW5rcywKQ2Flc2FyCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: caesar.upstream@gmail.com (Caesar Wang) Date: Mon, 15 Feb 2016 11:36:36 +0800 Subject: [PATCH v4 09/10] arm64: dts: Add main Thermal info to rk3368.dtsi In-Reply-To: <42802946.20XC68fnyM@phil> References: <1447044542-30859-1-git-send-email-wxt@rock-chips.com> <1447044542-30859-10-git-send-email-wxt@rock-chips.com> <42802946.20XC68fnyM@phil> Message-ID: <56C147C4.20704@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 2016?02?09? 16:30, Heiko Stuebner ??: > Hi Caesar, > > Am Montag, 9. November 2015, 12:49:01 schrieb Caesar Wang: >> This patch add the thermal needed info on RK3368. >> Meanwhile, support the trips to throttle for thermal. >> >> Signed-off-by: Caesar Wang >> Acked-by: Eduardo Valentin > [...] > >> @@ -829,6 +855,16 @@ >> }; >> }; >> >> + tsadc { >> + otp_gpio: otp-gpio { >> + rockchip,pins = <0 10 RK_FUNC_GPIO &pcfg_pull_none>; >> + }; >> + >> + otp_out: otp-out { >> + rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_none>; >> + }; >> + }; >> + >> uart0 { >> uart0_xfer: uart0-xfer { >> rockchip,pins = <2 24 RK_FUNC_1 &pcfg_pull_up>, > As it came up just now, these pinctrl settings seem strange. I.e. according > to the TRM gpio0b2 [= gpio0 10] func_1 is sc_rst, which seems to be the > smartcard controller? > > It came up because it seems the Tronsmart R68 board seems to use this pin > for controlling the vcc_host regulator instead. Yep, that's the incorrect over-temperature protection pin. :-( Fixed in https://patchwork.kernel.org/patch/8308831/ Thanks Heiko. > > Heiko > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip -- Thanks, Caesar